Skip to content

Fix comment regex#10

Open
oashour wants to merge 1 commit into
matteoacrossi:masterfrom
oashour:fix_comment_regex
Open

Fix comment regex#10
oashour wants to merge 1 commit into
matteoacrossi:masterfrom
oashour:fix_comment_regex

Conversation

@oashour

@oashour oashour commented Apr 11, 2024

Copy link
Copy Markdown

This PR fixes an issue with the comment stripping regex that would strip the character before a comment if there was no space.

This caused issues with parsing figure names if the .tex file looked like, e.g.,

\begin{figure}
\includegraphics[\linewidth]{myfig.pdf}%
\caption{whatever}
\end{figure}

, the }% would be stripped, leading to the imgname being myfig.pdf\n\caption{whatever.

@corettialessandro

Copy link
Copy Markdown

This is quite important, I recommend merging this PR. My estimate was over by 140 words due to this issue. @oashour Maybe also open an issue and link the PR so that it is easier to find. Thanks for the solution btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants