Regenerate the flag inventory, and say why the index-log compression flag has two paths - #1346
Merged
Merged
Conversation
…flag has two paths TS_INDEX_LOG_COMPRESSION_ENABLED and TS_INDEX_LOG_COMPRESSION_MIN_BYTES landed in index_log.rs without the generated inventory being regenerated, so test_every_flag_named_in_the_engine_is_listed and test_regenerating_produces_the_same_document are red on main and on every branch cut from it. Regenerating adds both rows and surfaces the boolean to test_a_two_path_flag_says_why, which wants a recorded reason for its off side. Taken from what the engine already says at the read: the flag gates only the WRITING of compressed payloads, reading codec 2 is unconditional, and that is what lets a store roll forward and back without a migration. This is the third time the inventory has gone stale this way. The detector works; it just reports on the next pull request rather than on the one that added the flag. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS_INDEX_LOG_COMPRESSION_ENABLEDandTS_INDEX_LOG_COMPRESSION_MIN_BYTESlanded inindex_log.rswithout the generated inventory being regenerated. Two guards are red on main because of it, and on every branch cut from main:test_every_flag_named_in_the_engine_is_listed— the engine names flags the document does not list.test_regenerating_produces_the_same_document— the counts on paper no longer match the tree.Regenerating adds both rows. That surfaces the boolean to
test_a_two_path_flag_says_why, which wants a recorded reason for its off side, so the second half of this supplies one taken from what the engine already says at the read:I derived that from the code rather than from the author, so if the intent was different the wording is the part to correct.
This is the third time
Same two guard names, third occurrence — #1269 and #1321 were the same thing with different flags. The detector works; it just reports on the next pull request rather than on the one that added the flag, so the cost lands on whoever pushes next and the staleness accumulates until someone regenerates.
Worth a maintainer decision rather than another regeneration from me: either the ratchet blocks merge, or the inventory stops being a committed artifact that can drift. I have not changed either here.
Checked:
test_a_two_path_flag_says_why,test_matrixark_engine_flag_inventory,test_matrixark_engine_settings_match_the_engine,test_matrixark_every_live_claim_is_checkedandtest_the_loader_maps_every_config_keyall pass. No engine code changes.🤖 Generated with Claude Code