Take the minimum PHP lint from the shared umbrella [ignore_release] - #657
Merged
Merged
Conversation
This workflow is a byte-identical copy in three repositories, and the umbrella now calls the shared plugin-min-php-lint.yml, so keeping it would run the same check twice. The shared one derives the floor from this plugin composer.json and plugin.json instead of hardcoding 8.1, fails when the lint path exists but holds no PHP, follows a symlinked path, and does not tell the maintainer to re-run the scoper -- the scoper prefixes but does not downgrade, so that advice was a no-op.
snake14
marked this pull request as ready for review
September 14, 2026 21:19
snake14
enabled auto-merge (squash)
September 14, 2026 21:19
lachiebol
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Important
Depends on matomo-org/plugin-ci-workflows#14. Merging this before that lands would remove the check entirely rather than move it, so this stays a draft until #14 is merged.
.github/workflows/min-php-lint.ymlis a byte-identical copy in three repositories — this one, plugin-ApiReference and plugin-SearchEngineKeywordsPerformance. Once #14 lands, theci.ymlumbrella calls the sharedplugin-min-php-lint.yml, so keeping the local copy would run the same check twice under the same job name.The shared workflow is a superset of this one:
composer.jsonandplugin.jsoninstead of hardcoding8.1, so it keeps tracking the declared minimum when that moves;findthat fails partway cannot leave a green check over a partial tree;%and newlines in annotations, so a multi-line parse error is not truncated to its first line.It also corrects the remediation advice. The local copy says "Re-run the scoper", but matomo-scoper prefixes without downgrading, so re-running it changes nothing; the shared one points at the two things that do fix it — lower
config.platform.phpand re-resolve, or raiserequire.phpif the declared floor is stale.No behaviour is lost: the job keeps the same name, and this plugin's floor resolves to the same
8.1the local copy hardcoded.Issue No
No GitHub issue.
Steps to Replicate the Issue
Checklist