Add escapeshell args for matomo domain, #AS-685 - #643
Merged
Conversation
sgiehl
approved these changes
Aug 19, 2026
snake14
approved these changes
Aug 19, 2026
snake14
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Do we need to bump the version and release?
AI listed an item, but I don't know if I'd really consider it blocking:
Blocking
- No regression test covers the shell-injection fix in Importer.php:291 and ImporterGA4.php:343. Existing importer tests leave custom-variable slots at zero, so importCustomVariableSlots() returns before reaching passthru(). A future regression could therefore reintroduce command injection while CI remains green. This violates the matomo-test-runner regression-coverage requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add escapeshell args for matomo domain, #AS-685
Issue No
Steps to Replicate the Issue
Checklist