Update the UI expected screenshots and specs for Matomo 6 - #642
Merged
Conversation
Six screenshots differ only by the Matomo 6 accent colour, synced from the CI artifacts of run 31569840370. The two GA4 import screenshots are deliberately not synced: on Matomo 6 the import form fails with a missing propertyId, which needs fixing first.
Vue's v-model does not receive jQuery's synthetic .val().change(), so on Matomo 6 the form submitted with an empty propertyId and no import was ever scheduled; the later spec steps failed on the missing import row.
Programmatically set values do not reach the Vue model even with native input/change events dispatched, while trusted typed input does (same pattern as the FormAnalytics specs).
The multituple scope select's option values still use the string: prefixed keys, and the radio needs waiting for before Vue mounts it.
…hots There has been no importer selection radio since GA3 was removed — the jQuery empty-set click just masked it, which is also why load_ga4 always equalled load. The six lifecycle screenshots are synced from the first run where the import flow actually executes on Matomo 6, each verified to show the correct import state.
snake14
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacks on #639 to make its UI leg green, in two parts.
Expected screenshots (12) — six differ only by the Matomo 6 theme (accent colour change) and are synced from the CI artifacts of run 31569840370. The other six cover the GA4 import lifecycle (started, errored, resumed, re-import range, finished, removed) and are synced from run 31682648525, the first run where that flow actually executes on Matomo 6 (see below) — each verified to show the correct import state in the new theme.
GA4 spec modernization — the spec drove the import form with jQuery (
$(...).val(...).change()and synthetic.click()), and on Matomo 6 those synthetic events no longer reach the Vue model, so the form submitted with an emptypropertyIdand failed with "The parameter 'propertyId' isn't set in the Request"; no import job was ever created and the rest of the spec cascade-failed on the missing import row. This first looked like a product regression, but it is test-only: filling the same fields with real typed keyboard events works, so actual users are unaffected. The spec now types the form values (with a verify-and-retry against swallowed first keystrokes, as the FormAnalytics specs do), fires a native change event for the scope select (whose option values keep theirstring:prefixed keys), and drops the interaction with the importer-selection radio — no such radio has existed since the GA3 importer's removal; jQuery's silent empty-set click masked that, which is also whyload_ga4.pnghas always been identical toload.png.Issue No
Related to #639.
Steps to Replicate the Issue
Checklist