Declare Timber directly instead of via LogcatCoreLib - #644
Closed
davidschreiber wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
CVE-2022-24329 in org.jetbrains.kotlin:kotlin-stdlib - medium severity
In JetBrains Kotlin before 1.6.0, it was not possible to lock dependencies for Multiplatform Gradle Projects.
Details
Remediation Aikido suggests bumping this package to version 1.6.0 to resolve this issue
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Collaborator
|
You are too late 😁 I did it some minutes before #643 |
Author
|
Alright, @hannesa2 even better! 👍🏼 Thanks a lot! I'll close mine then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the
LogcatCoreLibdependency of thetrackermodule with a direct dependency on Timber.Why
The tracker uses Timber for its logging (67 call sites across 16 files) but never declares it — Timber
arrives transitively, because
LogcatCoreLibexposes it atcompilescope. No class frominfo.hannes.*is referenced anywhere intracker/src/main, so the library itself is unused here.Declaring Timber directly makes that dependency explicit and drops four transitive artifacts from
every app that integrates the SDK:
For apps that ship an open source attribution screen, each of those also means one more entry to
track and keep licensed — which is how we noticed.
5.0.1is the version that was already being resolved transitively, so the Timber version on theclasspath does not change.
Scope
The
exampleappmodule keepsLogcatCoreLib: it genuinely uses it (DemoApp.ktinstallsinfo.hannes.timber.DebugFormatTree). This change only touches the publishedtrackermodule.Verification
Ran the same steps as the PR CI, all green:
./gradlew assembleDebug./gradlew check— 454 tests, 0 failures./gradlew :tracker:assembleRelease