Skip to content

Fix plugin.xml installation path - #8

Merged
mathias-luedtke merged 1 commit into
mathias-luedtke:ament-socketcan-interfacefrom
ruvu:fix-ament-socketcan-interface-plugin-xml
May 19, 2021
Merged

Fix plugin.xml installation path#8
mathias-luedtke merged 1 commit into
mathias-luedtke:ament-socketcan-interfacefrom
ruvu:fix-ament-socketcan-interface-plugin-xml

Conversation

@Rayman

@Rayman Rayman commented May 19, 2021

Copy link
Copy Markdown

Based on testing with the offical pluginlib_export_plugin_description_file macro, it seems that the current way of installing plugin.xml is in the wrong folder. It's one folder too deep. See the difference:

Installation with pluginlib:

pluginlib_export_plugin_description_file(socketcan_interface socketcan_interface_plugin.xml)

find -name '*plugin.xml'
./install/socketcan_interface/share/socketcan_interface/socketcan_interface_plugin.xml

cat ./install/socketcan_interface/share/ament_index/resource_index/socketcan_interface__pluginlib__plugin/socketcan_interface 
share/socketcan_interface/socketcan_interface_plugin.xml

Installed by current code:

find -name socketcan_interface_plugin.xml
./install/socketcan_interface/share/socketcan_interface/socketcan_interface_plugin.xml
./install/socketcan_interface/share/socketcan_interface/socketcan_interface_plugin.xml/socketcan_interface_plugin.xml

cat ./install/socketcan_interface/share/ament_index/resource_index/socketcan_interface__pluginlib__plugin/socketcan_interface 
share/socketcan_interface/socketcan_interface_plugin.xml

After this PR

find -name socketcan_interface_plugin.xml
./install/socketcan_interface/share/socketcan_interface/socketcan_interface_plugin.xml

cat ./install/socketcan_interface/share/ament_index/resource_index/socketcan_interface__pluginlib__plugin/socketcan_interface 
share/socketcan_interface/socketcan_interface_plugin.xml

I still could not verify if the plugin actually loads, but that's for another time.

@mathias-luedtke

Copy link
Copy Markdown
Owner

Thanks! It is basically the same fix as #6

@mathias-luedtke
mathias-luedtke merged commit b4af5a5 into mathias-luedtke:ament-socketcan-interface May 19, 2021
@Rayman
Rayman deleted the fix-ament-socketcan-interface-plugin-xml branch May 19, 2021 16:04
@Rayman

Rayman commented May 19, 2021

Copy link
Copy Markdown
Author

Whoops didn't see that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants