Fix plugin.xml installation path - #8
Merged
mathias-luedtke merged 1 commit intoMay 19, 2021
Merged
Conversation
Owner
|
Thanks! It is basically the same fix as #6 |
Author
|
Whoops didn't see that one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on testing with the offical
pluginlib_export_plugin_description_filemacro, it seems that the current way of installing plugin.xml is in the wrong folder. It's one folder too deep. See the difference:Installation with pluginlib:
Installed by current code:
After this PR
I still could not verify if the plugin actually loads, but that's for another time.