Skip to content

fix:move input view based on delta to handle all embedding cases - #15

Open
pevensen wants to merge 2 commits into
matghazaryan:masterfrom
pevensen:master
Open

fix:move input view based on delta to handle all embedding cases#15
pevensen wants to merge 2 commits into
matghazaryan:masterfrom
pevensen:master

Conversation

@pevensen

@pevensen pevensen commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

The previous change to adjust for the chat view controller being in a tab view controller does not work if the chat view controller is contained in its own navigation controller (it still shows a blank space the height of the tab bar).

This fix properly moves the input view regardless of how the chat view controller is embedded (i.e. it works with the current demo app with no embedding, it work if the chat view controller is embedded in a tab view controller with or without a navigation controller containing the chat view controller, and it works if the chat view controller is embedded in a navigation view controller).

Sorry I didn't catch this issue with the previous enhancement.

@pevensen

pevensen commented Aug 6, 2014

Copy link
Copy Markdown
Contributor Author

The message Text Entry position adjustment based on font size and entered text was also not set using global coordinates. I added that to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant