fix:move input view based on delta to handle all embedding cases - #15
Open
pevensen wants to merge 2 commits into
Open
fix:move input view based on delta to handle all embedding cases#15pevensen wants to merge 2 commits into
pevensen wants to merge 2 commits into
Conversation
Contributor
Author
|
The message Text Entry position adjustment based on font size and entered text was also not set using global coordinates. I added that to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous change to adjust for the chat view controller being in a tab view controller does not work if the chat view controller is contained in its own navigation controller (it still shows a blank space the height of the tab bar).
This fix properly moves the input view regardless of how the chat view controller is embedded (i.e. it works with the current demo app with no embedding, it work if the chat view controller is embedded in a tab view controller with or without a navigation controller containing the chat view controller, and it works if the chat view controller is embedded in a navigation view controller).
Sorry I didn't catch this issue with the previous enhancement.