Collect dependencies for dynamic replacements - #886
Closed
Andrew-S-Rosen wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
JobandFlowinputs to their output references.Response(replace=...)with only the captured transitive dependencies required by the returned replacement.Why
A dynamically created replacement job could reference another job created in the same function while omitting that dependency from
Response(replace=...). The replacement then failed because its output reference could not be resolved. Jobflow now tracks the dynamic construction context and builds the necessary dependency closure before preparing the replacement flow.User impact
This pattern now runs successfully without manually constructing a
Flow:Validation
python -m pytest tests/core/test_job.py tests/core/test_flow_decorator.py -q— 38 passed, 1 xfailedpython -m ruff check --ignore PLR0917 src/jobflow/core/job.py tests/core/test_job.py— passedgit diff --check— passed