Reverse pourbaix component#530
Conversation
…app about filter_solids
for more information, see https://pre-commit.ci
…toolkit into reverse_pourbaix
There was a problem hiding this comment.
It seems like _resolve_cutoff and _snap_to_grid are closely related to ReversePourbaixDiagramComponent. Is there a reason not to put them in the ReversePourbaixDiagramComponent as static methods like _format_cutoff_key?
| CUTOFF_STEP = 0.1 | ||
|
|
||
|
|
||
| def _resolve_cutoff(value) -> float: |
There was a problem hiding this comment.
It would be better to have a specific input type, either float or List[float]. I would prefer float, since if the input is a list, we only take the first element; we should handle this logic in the calling place.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…son data is included
…lkit into reverse_pourbaix
for more information, see https://pre-commit.ci
|
@minhsueh the component is also ready for review (not many changes from last time). Accompanies: https://github.com/materialsproject/web/pull/1451 |
|
@minhsueh small changes for the web app. Thanks in advance! Heatmap data: parquet instead of JSON Read parquet from S3 via pyarrow This just adds the parquet-heatmap path and S3 support that the companion web PR needs. TO DO: |
2 participants
Summary
Adds a reverse Pourbaix component and example app for demoing the new feature.
Context
This is a demo branch for the reverse pourbaix app. This is che component used for the web implimentation.
Changes
ReversePourbaixcomponent (crystal_toolkit/components/reverse_pourbaix.py)crystal_toolkit/apps/examples/reverse_pourbaix_example.py)reverse_pourbaix_heatmap.json)components/__init__.pyPrecomputed heatmap data is included in commit. Will be updated with up-to-date data later.
Status
Demo/draft. I will make a PR on web for the web implementation that makes this component.
How to view
Full example should be accessed form web.
@minhsueh please take look when you have a chance.