Skip to content

Fix tar.7z for 7zip - #554

Merged
vkareh merged 1 commit into
mate-desktop:masterfrom
2387skju:p7zip_drop_for_tar.7z
Aug 11, 2026
Merged

Fix tar.7z for 7zip#554
vkareh merged 1 commit into
mate-desktop:masterfrom
2387skju:p7zip_drop_for_tar.7z

Conversation

@2387skju

@2387skju 2387skju commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Fix this bug: Non working .tar.7z
Effected distributions: Debian, Ubuntu, Arch Linux ?, Fedora (mostly).
These distributions does not have the original commands 7zz 7zzs installed anymore (or not at default).
Therefore the legacy p7zip will be false detected:

if (g_strcmp0 (comm_tar->compress_command, "7zzs") != 0 && g_strcmp0 (comm_tar->compress_command, "7zz") != 0)
  fr_process_add_arg (comm->process, "-l"); // only valid for legacy p7zip

p7zip was dropped by mostly all distributions. So, we should be able to remove it safety.
Alternative: we can improve the p7zip detection: see here a working solution. But I prefer to drop it.


More details

List distributions: which are effected / non-effected:

distribution bug effected has commands
Debian 13 yes (tested) 7z 7za 7zr p7zip
Ubuntu 24.04 yes (tested) 7z 7za 7zr p7zip
ArchLinux / Manjaro yes (not tested) 7z 7za 7zr
fedora 44 yes (tested) 7z is the only one on live-CD ;
Each 7z* have an separated own package.
(only tested with live-CD)
OpenSuse no (tested) 7z 7za 7zr p7zip 7zz
alphine Linux no 7z 7zz
solus no 7z 7za 7zr 7zz
gentoo no 7z 7za 7zr 7zz
void linux no 7z 7za 7zr 7zz
FreeBSD / GhostBSD no 7z 7zz
Guix ?

List distributions: which dropped p7zip:

distribution year removed, or first year without
FreeBSD (/ GhostBSD ) 2022
Void Linux 2022
alphine Linux 2023
Arch Linux / Manjaro 2024 ~
Ubuntu 24.04 2024
OpenSuse 16.0 2025
Debian 13 2025
guix 2025
Fedora 44 2026
Solus 2026
gentoo 2026 (15.08.2026)

List distributions: which still has p7zip:

distribution has p7zip has 7zip year
salix 15 / Slackware? p7zip no last distribution release 2022 ;
last p7zip version from 2022 (=outdated)
NetBSD 11 p7zip 7zip last distribution release 30.06.2026 ;
p7zip seems the very very outdated version from year 2016 ( and not from newer following-up source ).
openindiana p7zip 7zip Year 2025: "expect ... p7zip will be removed..." ;
last p7zip version from 2025 ;

Note: If simultaneous p7zip & 7zip are installed: everything is OK. 7zz will be preferred, so this patch will correct work.

@vkareh vkareh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. It's not so much dropping p7zip support as it's dropping support for the -l flag, which is specific to p7zip, but all other 7z variants reject.

However, there's still a stray -l being added in the fr-command-7z.c file that you should remove as well.

@vkareh

vkareh commented Aug 6, 2026

Copy link
Copy Markdown
Member

@2387skju

2387skju commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

fr-command-7z.c :

Yes, I saw this also.

But, I wasn't able to provoke that problem here with a 7z file. ((I don't know why. ; And don't read / understand so much code of Engrampa currently.)) So, currently I wouldn't able to test my fix here.

This different to file-roller is a bit confusing:

  • We use the old recursive
  • file-roller use follow_links

So, I thought:

  1. First we should backport follow_links ("added option to follow symbolic links") ((maybe I will take a look at)) ,
  2. then we can remove p7zip also in fr-command-7z.c.

@2387skju
2387skju force-pushed the p7zip_drop_for_tar.7z branch from 293af48 to 5346a88 Compare August 10, 2026 17:11
@2387skju

2387skju commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

fr-command-7z.c :

OK, all clear.
Just the incomplete port of the variable / feature follow_links irritated me.
I've added this code commented out, for future use.

Feel free, to reduce my long commit message :-)

With kind regards.

@2387skju 2387skju changed the title tar.7z : fix by drop p7zip support .7z: drop p7zip support (fix for tar.7z) Aug 10, 2026
@2387skju 2387skju changed the title .7z: drop p7zip support (fix for tar.7z) Fix tar.7z for 7zip Aug 10, 2026
The -l switch doesn’t exist anymore.

command-7z:
 This old code was never called: Variable recursive is everytime FALSE in engrampa.

command-tar:
 This will fix this bug: Non working .tar.7z:
   Affected distributions: Debian, Ubuntu, Arch Linux ?, Fedora.
   These distributions do not have the original commands 7zz 7zzs installed anymore (or not at default).
   Therefore the legacy p7zip will be false detected.
@vkareh
vkareh force-pushed the p7zip_drop_for_tar.7z branch from 5346a88 to 778a65e Compare August 11, 2026 17:54
@vkareh
vkareh merged commit 426e765 into mate-desktop:master Aug 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants