Fix tar.7z for 7zip - #554
Conversation
vkareh
left a comment
There was a problem hiding this comment.
This looks fine. It's not so much dropping p7zip support as it's dropping support for the -l flag, which is specific to p7zip, but all other 7z variants reject.
However, there's still a stray -l being added in the fr-command-7z.c file that you should remove as well.
fr-command-7z.c :Yes, I saw this also. But, I wasn't able to provoke that problem here with a 7z file. ((I don't know why. ; And don't read / understand so much code of Engrampa currently.)) So, currently I wouldn't able to test my fix here. This different to
So, I thought:
|
293af48 to
5346a88
Compare
fr-command-7z.c :OK, all clear. Feel free, to reduce my long commit message :-) With kind regards. |
The -l switch doesn’t exist anymore. command-7z: This old code was never called: Variable recursive is everytime FALSE in engrampa. command-tar: This will fix this bug: Non working .tar.7z: Affected distributions: Debian, Ubuntu, Arch Linux ?, Fedora. These distributions do not have the original commands 7zz 7zzs installed anymore (or not at default). Therefore the legacy p7zip will be false detected.
5346a88 to
778a65e
Compare
Fix this bug: Non working .tar.7z
Effected distributions: Debian, Ubuntu, Arch Linux ?, Fedora (mostly).
These distributions does not have the original commands
7zz 7zzsinstalled anymore (or not at default).Therefore the legacy p7zip will be false detected:
p7zip was dropped by mostly all distributions. So, we should be able to remove it safety.
Alternative: we can improve the p7zip detection: see here a working solution. But I prefer to drop it.
More details
List distributions: which are effected / non-effected:
Each 7z* have an separated own package.
(only tested with live-CD)
List distributions: which dropped p7zip:
List distributions: which still has p7zip:
last p7zip version from 2022 (=outdated)
p7zip seems the very very outdated version from year 2016 ( and not from newer following-up source ).
last p7zip version from 2025 ;
Note: If simultaneous p7zip & 7zip are installed: everything is OK.
7zzwill be preferred, so this patch will correct work.