Skip to content

Complete React Todo App with API#2274

Open
eg3844540-svg wants to merge 1 commit into
mate-academy:masterfrom
eg3844540-svg:master
Open

Complete React Todo App with API#2274
eg3844540-svg wants to merge 1 commit into
mate-academy:masterfrom
eg3844540-svg:master

Conversation

@eg3844540-svg

Copy link
Copy Markdown

@raulriato raulriato left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take your time to componentize and write the best code you can for this project.

Comment thread src/App.tsx

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main feature of React is componentization. Since this is the main Todo App project that will be on your portfolio, I recommend you componentize it.

Comment thread src/App.tsx
Comment on lines +1 to 5
/* eslint-disable padding-line-between-statements */
/* eslint-disable @typescript-eslint/indent */
/* eslint-disable prettier/prettier */
/* eslint-disable jsx-a11y/label-has-associated-control */
/* eslint-disable jsx-a11y/control-has-associated-label */

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not disable eslint besides what the project already disables before your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants