solution#4343
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The Sum component uses separate JSX expressions instead of template literals as required by the style guide. Replace the paragraph content with a template literal:
{Sum of ${a} and ${b} is ${a + b}}
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -1,14 +1,13 @@ | |||
| import React from 'react'; | |||
| import './App.scss'; | |||
| import { Sum } from './components/Sum/Sum'; | |||
There was a problem hiding this comment.
This violates checklist item #2: Use string interpolation inside tag content. The current implementation uses separate JSX expressions Sum of {a} and {b} is {a + b} instead of a template literal like {Sum of ${a} and ${b} is ${a + b}}
| <p> | ||
| Sum of {a} and {b} is {a + b} | ||
| </p> |
There was a problem hiding this comment.
Checklist item #2 violation: Use string interpolation (template literals) inside tag content. Replace with {Sum of ${a} and ${b} is ${a + b}} instead of separate text nodes and JSX expressions.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation is approved and meets all requirements. The Sum component correctly uses a named export with proper default values (a=0, b=0) and template literals for displaying the sum result. All five required component instances are present in App.jsx with the correct prop combinations: <Sum a={2} b={3} />, <Sum a={-5} b={5} />, <Sum a={10} />, <Sum b={5} />, and <Sum />. The code follows the style guidelines with single-line JSX for components with fewer than 3 attributes. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK