SolV1#2033
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Overall, great work—your app meets the core requirements and functions correctly. Components are well-structured, types are accurate, keys are properly used, and class names are preserved.
Minor issue to address in future updates (non-blocking):
- Checklist item #5: Prefer single-expression string interpolation in JSX over multiple {' '} insertions.
- In src/components/CommentInfo/CommentInfo.tsx: Replace the
{' by '}separation betweennameandemailwith interpolation. For example, if you currently have something like:{comment.name}{' by '}{comment.email}, consider{${comment.name} by ${comment.email}}. - In src/components/PostInfo/PostInfo.tsx: Replace
{' Posted by '}before theUserInfocomponent with an interpolated string in a single expression, e.g., wrap the text and component in a single expression or restructure so the label and content are combined without manual space insertions.
- In src/components/CommentInfo/CommentInfo.tsx: Replace the
These are stylistic and won’t block functionality, but aligning with the checklist will keep your codebase consistent. Nice job—keep it up!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| <div className="CommentInfo"> | ||
| <div className="CommentInfo__title"> | ||
| <strong className="CommentInfo__name">{comment.name}</strong> | ||
| {' by '} |
There was a problem hiding this comment.
This violates checklist item #5: "When combining multiple string parts and variables in tag content, prefer string interpolation in a single expression rather than multiple {' '} insertions." Consider using a single string interpolation for the name, 'by', and email instead of separating them with {' by '}.
| <h3 className="PostInfo__title">{post.title}</h3> | ||
|
|
||
| <p> | ||
| {' Posted by '} |
There was a problem hiding this comment.
This violates checklist item #5: "When combining multiple string parts and variables in tag content, prefer string interpolation in a single expression rather than multiple {' '} insertions." Consider using a single string interpolation for the 'Posted by' text and the UserInfo component instead of separating them with {' Posted by '}.
https://tomaszkrzywicki.github.io/react_static-list-of-posts/