Skip to content

init commit#2019

Open
nex1994 wants to merge 5 commits into
mate-academy:masterfrom
nex1994:develop
Open

init commit#2019
nex1994 wants to merge 5 commits into
mate-academy:masterfrom
nex1994:develop

Conversation

@nex1994

@nex1994 nex1994 commented Jan 8, 2025

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the task! 🎉 Your code meets the core requirements and functions correctly. While there are a few minor improvements suggested, such as using string interpolation for better readability and ensuring descriptive function names, these do not impact the functionality. Keep up the good work and consider the feedback for future enhancements! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@natalia-klonowska natalia-klonowska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

Comment thread src/components/PostInfo/PostInfo.tsx Outdated
</div>
<p className="PostInfo__body">{post.body}</p>
<hr />
{post.comments !== undefined && post.comments.length > 0 ? (

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can shorten it

Suggested change
{post.comments !== undefined && post.comments.length > 0 ? (
{post.comments && post.comments.length ? (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants