task solution#2017
Open
W3zzie wants to merge 2 commits into
Open
Conversation
zibi-dev
approved these changes
Sep 25, 2024
zibi-dev
left a comment
zibi-dev
left a comment
There was a problem hiding this comment.
Good job! 🥇 . I have left some comments for future reference.
Comment on lines
+9
to
+13
| export const UserInfo: React.FC<Props> = ({ user }) => ( | ||
| <a className="UserInfo" href={`mailto:${user?.email}`}> | ||
| {user?.name} | ||
| </a> | ||
| ); |
| import { CommentInfo } from '../CommentInfo'; | ||
|
|
||
| export const CommentList: React.FC = () => <>Put the list here</>; | ||
| export const CommentList: React.FC<{ comments: Comment[] }> = ({ |
There was a problem hiding this comment.
Once you declare the type interface and once you do not, stay consistent with your approach.
| import { Comment } from '../../types/Comment'; | ||
|
|
||
| export const CommentInfo: React.FC = () => <>Put the comment here</>; | ||
| export const CommentInfo: React.FC<{ comment: Comment }> = ({ |
There was a problem hiding this comment.
Here is an article on why you shouldn't use React.FC https://dev.to/elhamnajeebullah/react-typescript-what-is-reactfc-and-why-should-i-use-it-4029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEMO LINK