Skip to content

feat: updated components for the app#4485

Open
thorn086 wants to merge 2 commits into
mate-academy:masterfrom
thorn086:master
Open

feat: updated components for the app#4485
thorn086 wants to merge 2 commits into
mate-academy:masterfrom
thorn086:master

Conversation

@thorn086

@thorn086 thorn086 commented Jul 5, 2026

Copy link
Copy Markdown

Updated app to handle new components

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there are still critical, blocking issues relative to the task requirements and tests. The navigation block is not extracted into its own Navigation component and folder, and its styles remain in App.css; this violates the requirement to decompose by BEM/CSS blocks and [CHECKLIST ITEM #2] about a separate folder per component. You need to create a Navigation component (e.g., src/components/Navigation/Navigation.jsx with Navigation.css), move the <nav className="navigation">...</nav> from Header.jsx into it, and move all .navigation / .navigation__link styles from App.css into Navigation.css, then import and use Navigation inside Header. Tests are also failing due to CSS issues: the Article media query font size is half of what the tests expect (22.4px instead of 44.8px), and the Header CSS has incorrect opacity (should be 0.7) and media-query display (should be flex, not block), so you need to adjust these styles to match the expected responsive behavior. Additionally, there are redundant blank lines in Article.jsx around the component and default export, which conflicts with [CHECKLIST ITEM #1] about not overusing empty lines; tighten this spacing by removing the unnecessary empty lines. Finally, make sure any new files like Navigation.jsx and Navigation.css are added to git and that your PR description includes the required GitHub Pages DEMO link, as specified in the task. Once these structural and CSS issues are fixed, your solution will align well with the requirements, as your current component structure and default exports are otherwise solid.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/components/Article/Article.css
Comment thread src/components/Article/Article.css
Comment thread src/components/Article/Article.jsx
Comment thread src/components/Article/Article.jsx
Comment thread src/components/Header/Header.jsx
@thorn086

thorn086 commented Jul 5, 2026

Copy link
Copy Markdown
Author

added changes and updated tests

@thorn086 thorn086 closed this Jul 5, 2026
@thorn086 thorn086 reopened this Jul 5, 2026

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution as an educational override so you can move forward while continuing to learn and improve.

You’ve done a solid job decomposing App into Header, Article, and Welcome, and your header media-query now correctly uses display: flex, which aligns with the responsive requirement. The main structural gap is that the <nav className="navigation">...</nav> block is still inside Header.jsx instead of being moved into its own Navigation component and folder, and the .navigation / .navigation__link styles are still in Header.css instead of a dedicated Navigation.css [CHECKLIST ITEM #2]. In addition, tests expect opacity: 0.7 on .header in Header.css and an Article media-query font-size of 44.8px in Article.css, which are currently missing and will cause style-related test failures. As you iterate, aim to (1) create src/components/Navigation/Navigation.jsx and Navigation.css, move the <nav> markup and navigation styles there, and import <Navigation /> inside Header, and (2) add opacity: 0.7; to .header plus the font-size: 44.8px; in the appropriate @media rule for .article.

Your solution is approved so you can progress, and addressing these points next will help you match the project’s decomposition and styling requirements more closely.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/App.jsx
Comment thread src/App.jsx
Comment thread src/components/Article/Article.css
Comment thread src/components/Article/Article.css
Comment thread src/components/Article/Article.css
Comment thread src/components/Header/Header.css
Comment thread src/components/Header/Header.css
Comment thread src/components/Header/Header.css
Comment thread src/components/Header/Header.css
Comment thread src/components/Header/Header.jsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants