Skip to content

solution1#197

Open
Alexey211220 wants to merge 1 commit into
mate-academy:mainfrom
Alexey211220:develop
Open

solution1#197
Alexey211220 wants to merge 1 commit into
mate-academy:mainfrom
Alexey211220:develop

Conversation

@Alexey211220

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution because it correctly normalizes the ShopDB schema to 3NF and meets the core functional requirements of the task. You decomposed the original ProductInventory into separate Products, Warehouses, and an inventory table with foreign keys, eliminating repeated warehouse and product attributes while preserving the original test data semantics (two countries, two warehouses, one product with different quantities per warehouse). The DDL syntax is valid MySQL, keys and foreign keys are properly defined, and the INSERT statements align with the new schema and represent the same logical data as described.

One improvement for future work is to consider adding DROP DATABASE IF EXISTS ShopDB; at the top of task.sql to match the instruction to drop the database before recreating it and to avoid issues when rerunning the script. It would also be good practice to mark primary key and other required columns as NOT NULL to strengthen data integrity, although this is not required for the current assignment. Overall, your solution demonstrates a solid understanding of normalization and relational design, and you’re on the right track—nicely done.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants