Skip to content

Normalization of the Shopbd database#196

Open
TrickyTenshi wants to merge 2 commits into
mate-academy:mainfrom
TrickyTenshi:develop
Open

Normalization of the Shopbd database#196
TrickyTenshi wants to merge 2 commits into
mate-academy:mainfrom
TrickyTenshi:develop

Conversation

@TrickyTenshi

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because the current ProductInventory schema does not match the explicitly required column set, which will cause the provided tests to fail and block task completion. The task description requires ProductInventory to have columns ID, ProductName, WarehouseAmount, WarehouseName, WarehouseAddress, and CountryID, but your table instead uses ProductID and WarehouseID, so the structure the tests expect is not present. In task.sql, update the CREATE TABLE ProductInventory statement so that it defines exactly those six columns with appropriate types, and remove or adapt any foreign-key-based design that relies on ProductID/WarehouseID in this table. After changing the schema, fix the INSERT statements that currently populate ProductID and WarehouseID so they instead insert ProductName, WarehouseAmount, WarehouseName, WarehouseAddress, and CountryID values that represent the same logical test data. You can still keep separate Products and Warehouses tables conceptually if you like, but for this exercise the ProductInventory table itself must follow the fixed denormalized format that the tests and task description specify. Additionally, add the required DROP DATABASE ShopDB; at the top of task.sql so the database can be recreated cleanly during testing. Overall, you’ve done solid work on normalization and data alignment; once these schema and insert adjustments are made to meet the exact contract, your solution should satisfy all requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread task.sql
Comment thread task.sql

@k5sha k5sha left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Great responses to the AI's comments, keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants