-
Notifications
You must be signed in to change notification settings - Fork 181
Done #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Done #195
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,14 +9,29 @@ CREATE TABLE Countries ( | |
| PRIMARY KEY (ID) | ||
| ); | ||
|
|
||
| CREATE TABLE ProductInventory ( | ||
| ID INT, | ||
| CREATE TABLE Products ( | ||
| ID INT AUTO_INCREMENT, | ||
| ProductName VARCHAR(50), | ||
| WarehouseAmount INT, | ||
| PRIMARY KEY (ID) | ||
| ); | ||
|
Comment on lines
+12
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
| CREATE TABLE Warehouses ( | ||
| ID INT AUTO_INCREMENT, | ||
| WarehouseName VARCHAR(50), | ||
| WarehouseAddress VARCHAR(50), | ||
| WarehouseAddress VARCHAR(50), | ||
| CountryID INT, | ||
| FOREIGN KEY (CountryID) REFERENCES Countries(ID) ON DELETE NO ACTION, | ||
| FOREIGN KEY (CountryID) REFERENCES Countries(ID) ON DELETE NO ACTION, | ||
| PRIMARY KEY (ID) | ||
|
Comment on lines
+18
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency and easier test data management, it would be beneficial to make this
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||
| ); | ||
|
Comment on lines
+18
to
+25
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
|
||
|
|
||
| CREATE TABLE ProductInventory ( | ||
| ID INT AUTO_INCREMENT, | ||
| ProductID INT, | ||
| FOREIGN KEY (ProductID) REFERENCES Products(ID) ON DELETE CASCADE, | ||
| WarehouseAmount INT, | ||
| WarehouseID INT, | ||
| FOREIGN KEY (WarehouseID) REFERENCES Warehouses(ID) ON DELETE CASCADE, | ||
| PRIMARY KEY (ID) | ||
|
Comment on lines
+28
to
35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You may also want
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. added |
||
| ); | ||
|
|
||
|
|
@@ -26,8 +41,19 @@ INSERT INTO Countries (ID,Name) | |
| VALUES (1, 'Country1'); | ||
| INSERT INTO Countries (ID,Name) | ||
| VALUES (2, 'Country2'); | ||
|
|
||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (1, 'AwersomeProduct', 2, 'Warehouse-1', 'City-1, Street-1',1); | ||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (2, 'AwersomeProduct', 5, 'Warehouse-2', 'City-2, Street-2',2); | ||
|
|
||
| INSERT INTO Products (ID,ProductName) | ||
| VALUES (1, 'Product1'); | ||
| INSERT INTO Products (ID,ProductName) | ||
| VALUES (2, 'Product2'); | ||
|
|
||
| INSERT INTO Warehouses (ID,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (1, 'Warehouse1', 'Address1', 1); | ||
|
|
||
| INSERT INTO Warehouses (ID,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (2, 'Warehouse2', 'Address2', 2); | ||
|
|
||
| INSERT INTO ProductInventory (ID,ProductID,WarehouseAmount,WarehouseID) | ||
| VALUES (1, 1, 2, 1); | ||
| INSERT INTO ProductInventory (ID,ProductID,WarehouseAmount,WarehouseID) | ||
| VALUES (2, 1, 5, 2); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, consider declaring
IDasINT AUTO_INCREMENThere to match the recommended improvement for primary keys.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added