Skip to content

Normalize ShopDB to 3NF#174

Open
Enscream wants to merge 3 commits into
mate-academy:mainfrom
Enscream:main
Open

Normalize ShopDB to 3NF#174
Enscream wants to merge 3 commits into
mate-academy:mainfrom
Enscream:main

Conversation

@Enscream

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The task requirements explicitly specify that the ProductInventory table must contain columns: ID, ProductName, WarehouseAmount, WarehouseName, WarehouseAddress, and CountryID. However, your implementation uses ProductID and WarehouseID (foreign keys) instead. While your normalized junction table approach is correct for database design, it won't pass the tests which expect the specific column names listed in the requirements. You need to add a ProductName column to the Products table and include ProductName, WarehouseName, WarehouseAddress columns directly in the ProductInventory table as specified in the requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@Losiev Losiev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should solve this task, so GitHub tests pass

@Enscream

Enscream commented Jun 2, 2026

Copy link
Copy Markdown
Author

We should solve this task, so GitHub tests pass

Now its passed, check please. Have a nice evening

@linubah linubah left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants