Normalize ShopDB to 3NF#174
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The task requirements explicitly specify that the ProductInventory table must contain columns: ID, ProductName, WarehouseAmount, WarehouseName, WarehouseAddress, and CountryID. However, your implementation uses ProductID and WarehouseID (foreign keys) instead. While your normalized junction table approach is correct for database design, it won't pass the tests which expect the specific column names listed in the requirements. You need to add a ProductName column to the Products table and include ProductName, WarehouseName, WarehouseAddress columns directly in the ProductInventory table as specified in the requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
Losiev
left a comment
There was a problem hiding this comment.
We should solve this task, so GitHub tests pass
Now its passed, check please. Have a nice evening |
No description provided.