feat: solution#136
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
You've made a great start on this task by creating the WarehouseInfo table to separate warehouse details. However, some changes are needed because the database schema is not yet in the third normal form (3NF).
The main issue is in your task.sql file. The ProductInventory table still contains the ProductName column, which creates data redundancy. To resolve this, you should create a separate Products table for product information and use a ProductID foreign key in the ProductInventory table to link to it.
Additionally, please remember to include the DROP DATABASE IF EXISTS ShopDB; statement at the beginning of your script. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on separating the tables! This is a big step in the right direction. However, I am requesting a few changes as the schema is not yet in the third normal form (3NF), which is a core requirement of the task.
The main issue is that the Products table still contains inventory-related columns like WarehouseAmount and WarehouseID. To achieve 3NF, the Products table should only contain data that describes the product itself (e.g., ID, ProductName). The inventory information should be moved to the ProductInventory table, which would link products to warehouses and store the quantity.
Also, please remember to add the DROP DATABASE IF EXISTS ShopDB; statement at the beginning of your script to ensure it can be run multiple times without errors. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work normalizing the database schema to the third normal form! Your separation of data into Products, WarehouseInfo, and ProductInventory tables is perfectly done.
I am approving this solution as an educational override so you can proceed, but there is one critical requirement to address for future submissions. Your script will fail if run more than once because the database will already exist. To ensure your script is re-runnable, please add DROP DATABASE IF EXISTS ShopDB; at the very beginning of your task.sql file, before the CREATE DATABASE statement. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.