Skip to content

Update task.sql#132

Closed
yurii-chornyi wants to merge 1 commit into
mate-academy:mainfrom
yurii-chornyi:yurii-chornyi-patch-2
Closed

Update task.sql#132
yurii-chornyi wants to merge 1 commit into
mate-academy:mainfrom
yurii-chornyi:yurii-chornyi-patch-2

Conversation

@yurii-chornyi

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on normalizing the database schema to the third normal form! You've correctly identified the entities and updated the INSERT statements to match the new structure.

However, I am requesting a small change because the script is missing a required command. If the ShopDB database already exists, the script will fail on a second run. To make the script re-runnable and meet all requirements, please add the following statement at the very beginning of your task.sql file:

DROP DATABASE IF EXISTS ShopDB;

Once you add this line, your solution will be perfect. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread task.sql

CREATE DATABASE ShopDB;
USE ShopDB;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires the script to delete the ShopDB database if it already exists. To meet this requirement and make the script re-runnable, you should add the DROP DATABASE IF EXISTS ShopDB; statement before creating the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants