Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 32 additions & 15 deletions task.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
-- Create database and tables
DROP DATABASE IF EXISTS ShopDB;

CREATE DATABASE ShopDB;
USE ShopDB;
Expand All @@ -9,25 +9,42 @@ CREATE TABLE Countries (
PRIMARY KEY (ID)
);

CREATE TABLE ProductInventory (
CREATE TABLE WareHouses (
ID INT,
ProductName VARCHAR(50),
WarehouseAmount INT,
WarehouseName VARCHAR(50),
WarehouseAddress VARCHAR(50),
WarehouseAddress VARCHAR(50),
CountryID INT,
FOREIGN KEY (CountryID) REFERENCES Countries(ID) ON DELETE NO ACTION,
PRIMARY KEY (ID)
);

-- Populate test data
CREATE TABLE Products (
ID INT,
ProductName VARCHAR(50),
PRIMARY KEY (ID)
);

CREATE TABLE ProductInventory (
ID INT,
ProductID INT,
WarehouseID INT,
WarehouseAmount INT,
FOREIGN KEY (ProductID) REFERENCES Products(ID) ON DELETE NO ACTION,
FOREIGN KEY (WarehouseID) REFERENCES WareHouses(ID) ON DELETE NO ACTION,
PRIMARY KEY (ID)
);

INSERT INTO Countries (ID,Name)
VALUES (1, 'Country1');
INSERT INTO Countries (ID,Name)
VALUES (2, 'Country2');
INSERT INTO Countries (ID, Name)
VALUES (1, 'Country1'),
(2, 'Country2');

INSERT INTO WareHouses (ID, WarehouseName, WarehouseAddress, CountryID)
VALUES (1, 'Main Warehouse', 'Address 1', 1),
(2, 'Backup Warehouse', 'Address 2', 2);

INSERT INTO Products (ID, ProductName)
VALUES (1, 'AwersomeProduct'),
(2, 'AwersomeProduct');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've correctly created the Products table to normalize the data. However, by inserting 'AwersomeProduct' twice with two different IDs, you are re-introducing data redundancy. The purpose of this table is to have a single entry for each unique product. You should insert 'AwersomeProduct' only once.


INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID)
VALUES (1, 'AwersomeProduct', 2, 'Warehouse-1', 'City-1, Street-1',1);
INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID)
VALUES (2, 'AwersomeProduct', 5, 'Warehouse-2', 'City-2, Street-2',2);
INSERT INTO ProductInventory (ID, ProductID, WarehouseID, WarehouseAmount)
VALUES (1, 1, 1, 100),
(2, 2, 2, 200);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the correction to avoid duplicate products in the Products table, this row should be updated to use the single ProductID for 'AwersomeProduct' to indicate that the same product is in this second warehouse.