-
Notifications
You must be signed in to change notification settings - Fork 182
Solution v1 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
whatislavx
wants to merge
3
commits into
mate-academy:main
Choose a base branch
from
whatislavx:devops/databases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Solution v1 #129
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| -- Create database and tables | ||
| DROP DATABASE IF EXISTS ShopDB; | ||
|
|
||
| CREATE DATABASE ShopDB; | ||
| USE ShopDB; | ||
|
|
@@ -9,25 +9,42 @@ CREATE TABLE Countries ( | |
| PRIMARY KEY (ID) | ||
| ); | ||
|
|
||
| CREATE TABLE ProductInventory ( | ||
| CREATE TABLE WareHouses ( | ||
| ID INT, | ||
| ProductName VARCHAR(50), | ||
| WarehouseAmount INT, | ||
| WarehouseName VARCHAR(50), | ||
| WarehouseAddress VARCHAR(50), | ||
| WarehouseAddress VARCHAR(50), | ||
| CountryID INT, | ||
| FOREIGN KEY (CountryID) REFERENCES Countries(ID) ON DELETE NO ACTION, | ||
| PRIMARY KEY (ID) | ||
| ); | ||
|
|
||
| -- Populate test data | ||
| CREATE TABLE Products ( | ||
| ID INT, | ||
| ProductName VARCHAR(50), | ||
| PRIMARY KEY (ID) | ||
| ); | ||
|
|
||
| CREATE TABLE ProductInventory ( | ||
| ID INT, | ||
| ProductID INT, | ||
| WarehouseID INT, | ||
| WarehouseAmount INT, | ||
| FOREIGN KEY (ProductID) REFERENCES Products(ID) ON DELETE NO ACTION, | ||
| FOREIGN KEY (WarehouseID) REFERENCES WareHouses(ID) ON DELETE NO ACTION, | ||
| PRIMARY KEY (ID) | ||
| ); | ||
|
|
||
| INSERT INTO Countries (ID,Name) | ||
| VALUES (1, 'Country1'); | ||
| INSERT INTO Countries (ID,Name) | ||
| VALUES (2, 'Country2'); | ||
| INSERT INTO Countries (ID, Name) | ||
| VALUES (1, 'Country1'), | ||
| (2, 'Country2'); | ||
|
|
||
| INSERT INTO WareHouses (ID, WarehouseName, WarehouseAddress, CountryID) | ||
| VALUES (1, 'Main Warehouse', 'Address 1', 1), | ||
| (2, 'Backup Warehouse', 'Address 2', 2); | ||
|
|
||
| INSERT INTO Products (ID, ProductName) | ||
| VALUES (1, 'AwersomeProduct'), | ||
| (2, 'AwersomeProduct'); | ||
|
|
||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (1, 'AwersomeProduct', 2, 'Warehouse-1', 'City-1, Street-1',1); | ||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (2, 'AwersomeProduct', 5, 'Warehouse-2', 'City-2, Street-2',2); | ||
| INSERT INTO ProductInventory (ID, ProductID, WarehouseID, WarehouseAmount) | ||
| VALUES (1, 1, 1, 100), | ||
| (2, 2, 2, 200); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Following the correction to avoid duplicate products in the |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've correctly created the
Productstable to normalize the data. However, by inserting'AwersomeProduct'twice with two different IDs, you are re-introducing data redundancy. The purpose of this table is to have a single entry for each unique product. You should insert'AwersomeProduct'only once.