Dev#126
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Hello! You've made a great start on normalizing the database by creating the Warehouse table. However, a couple of changes are needed before this can be approved.
First, the database normalization isn't complete. The task requires achieving Third Normal Form (3NF), but the ProductInventory table still contains a redundant ProductName column, as seen in your INSERT statements. To fix this, you should create a separate Products table and reference it from ProductInventory using a foreign key.
Additionally, the script is missing the required DROP DATABASE IF EXISTS ShopDB; command at the beginning. This will cause an error if the script is run more than once, which is a key requirement.
Please address these two points and resubmit. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| VALUES (1, 'Warehouse-1', 'City-1, Street-1'), | ||
| (2, 'Warehouse-2', 'City-2, Street-2'); | ||
|
|
||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseID,CountryID) |
There was a problem hiding this comment.
This INSERT statement highlights an issue with the table schema. Including ProductName directly in the ProductInventory table leads to data redundancy, as seen in the following lines where 'AwersomeProduct' is repeated. To fully normalize the database, you should create a separate Products table and reference it with a ProductID foreign key in ProductInventory.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I am approving your solution as you've successfully addressed all the feedback from the previous review. The script now correctly includes the DROP DATABASE statement, ensuring it can be re-run without issues. You've done a great job normalizing the database to the Third Normal Form (3NF) by creating the separate Product and Warehouse tables and linking them through the ProductInventory table. The solution now fully meets all the task requirements. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.