-
Notifications
You must be signed in to change notification settings - Fork 182
ready for task #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ready for task #124
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,52 @@ | ||
| -- Create database and tables | ||
|
|
||
| CREATE DATABASE ShopDB; | ||
| USE ShopDB; | ||
|
|
||
| CREATE TABLE Countries ( | ||
| ID INT, | ||
| Name VARCHAR(50), | ||
| PRIMARY KEY (ID) | ||
| ); | ||
| ID INT AUTO_INCREMENT PRIMARY KEY, | ||
| Name VARCHAR(50) NOT NULL | ||
| ) ENGINE=InnoDB; | ||
|
|
||
| CREATE TABLE Warehouses ( | ||
| ID INT AUTO_INCREMENT PRIMARY KEY, | ||
| WarehouseName VARCHAR(50) NOT NULL, | ||
| WarehouseAddress VARCHAR(100), | ||
| CountryID INT NOT NULL, | ||
| FOREIGN KEY (CountryID) REFERENCES Countries(ID) | ||
| ON DELETE RESTRICT | ||
| ON UPDATE CASCADE | ||
| ) ENGINE=InnoDB; | ||
|
|
||
| CREATE TABLE Products ( | ||
| ID INT AUTO_INCREMENT PRIMARY KEY, | ||
| ProductName VARCHAR(50) NOT NULL | ||
| ) ENGINE=InnoDB; | ||
|
|
||
| CREATE TABLE ProductInventory ( | ||
| ID INT, | ||
| ProductName VARCHAR(50), | ||
| WarehouseAmount INT, | ||
| WarehouseName VARCHAR(50), | ||
| WarehouseAddress VARCHAR(50), | ||
| CountryID INT, | ||
| FOREIGN KEY (CountryID) REFERENCES Countries(ID) ON DELETE NO ACTION, | ||
| PRIMARY KEY (ID) | ||
| ); | ||
|
|
||
| -- Populate test data | ||
|
|
||
| INSERT INTO Countries (ID,Name) | ||
| VALUES (1, 'Country1'); | ||
| INSERT INTO Countries (ID,Name) | ||
| VALUES (2, 'Country2'); | ||
|
|
||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (1, 'AwersomeProduct', 2, 'Warehouse-1', 'City-1, Street-1',1); | ||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (2, 'AwersomeProduct', 5, 'Warehouse-2', 'City-2, Street-2',2); | ||
| ID INT AUTO_INCREMENT PRIMARY KEY, | ||
| ProductID INT NOT NULL, | ||
| WarehouseID INT NOT NULL, | ||
| WarehouseAmount INT UNSIGNED NOT NULL CHECK (WarehouseAmount >= 0), | ||
| FOREIGN KEY (ProductID) REFERENCES Products(ID) | ||
| ON DELETE CASCADE | ||
| ON UPDATE CASCADE, | ||
| FOREIGN KEY (WarehouseID) REFERENCES Warehouses(ID) | ||
|
Comment on lines
24
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The ProductInventory table uses a surrogate ID but does not enforce uniqueness on the logical key (ProductID, WarehouseID). Per the requirements, the inventory amount must depend on the product+warehouse pair — add a UNIQUE(ProductID, WarehouseID) constraint or make (ProductID, WarehouseID) the composite primary key to prevent duplicate inventory rows and ensure 3NF. |
||
| ON DELETE CASCADE | ||
| ON UPDATE CASCADE, | ||
| UNIQUE (ProductID, WarehouseID) | ||
| ) ENGINE=InnoDB; | ||
|
|
||
| INSERT INTO Countries (Name) | ||
| VALUES ('Country1'), ('Country2'); | ||
|
|
||
| INSERT INTO Warehouses (WarehouseName, WarehouseAddress, CountryID) | ||
| VALUES | ||
| ('Warehouse-1', 'City-1, Street-1', 1), | ||
| ('Warehouse-2', 'City-2, Street-2', 2); | ||
|
|
||
| INSERT INTO Products (ProductName) | ||
| VALUES ('AwesomeProduct'); | ||
|
|
||
| INSERT INTO ProductInventory (ProductID, WarehouseID, WarehouseAmount) | ||
| VALUES | ||
| (1, 1, 2), | ||
| (1, 2, 5); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added
INT UNSIGNED NOT NULL CHECK (WarehouseAmount >= 0)which is good to prevent negative inventory. Note: older MySQL versions may ignoreCHECKconstraints, butINT UNSIGNEDenforces non-negative values. This is an informational note — no change required unless you need to support very old MySQL versions.