Solution#108
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Thank you for your hard work on normalizing the ShopDB database! Before your solution can be approved, please address these critical issues: (1) The order of columns in the INSERT statements for the Addresses table does not match the table definition—please ensure the values are in the correct order; (2) The Warehouses table's INSERT statements are missing values for the WarehouseAddress column, which will cause errors. Once you fix these, your script should work as expected. Keep going, you're almost there! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| INSERT INTO Addresses (ID,Street,City,CountryID) | ||
| VALUES (1, 'City-1', 'Street-1', 1); |
There was a problem hiding this comment.
Issue: The order of values in the INSERT statement does not match the column order in the Addresses table definition. It should be (ID, Street, City, CountryID) but you have ('City-1', 'Street-1', 1). Please correct the order of values.
| INSERT INTO Addresses (ID,Street,City,CountryID) | ||
| VALUES (2, 'City-2', 'Street-2', 2); |
There was a problem hiding this comment.
Issue: The order of values in the INSERT statement does not match the column order in the Addresses table definition. It should be (ID, Street, City, CountryID) but you have ('City-2', 'Street-2', 2). Please correct the order of values.
| INSERT INTO Warehouses (ID,WarehouseName,WarehouseAmount) | ||
| VALUES (1, 'Warehouse-1', 2); |
There was a problem hiding this comment.
Error: The Warehouses table definition includes a WarehouseAddress column, but the INSERT statement does not provide a value for it. You need to include a value for WarehouseAddress in the INSERT statement.
| INSERT INTO Warehouses (ID,WarehouseName,WarehouseAmount) | ||
| VALUES (2, 'Warehouse-2', 5); |
There was a problem hiding this comment.
Error: The Warehouses table definition includes a WarehouseAddress column, but the INSERT statement does not provide a value for it. You need to include a value for WarehouseAddress in the INSERT statement.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Fantastic work! 🎉 Your updated task.sql fully meets all the requirements for 3NF normalization. The schema is well-structured, all test data is preserved, and previous issues have been resolved. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| CREATE TABLE Warehouses( | ||
| ID INT, | ||
| WarehouseName VARCHAR(50), | ||
| WarehouseAmount INT, | ||
| PRIMARY KEY (ID) | ||
| ); |
There was a problem hiding this comment.
Potential issue: The Warehouses table does not include a WarehouseAddress column. If the task requires each warehouse to have an address (as suggested by the checklist or requirements), you should add a WarehouseAddress (or AddressID) column and update the INSERT statements accordingly.
2 participants
No description provided.