Database Normalization#107
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your submission includes both the original and normalized schemas in task.sql, with a DROP DATABASE statement in the middle, making the first part redundant and violating the requirement to only include the normalized schema and adapted test data. Please update your script to contain only the normalized (3NF) schema and the corresponding adapted INSERT statements. Once you make these changes, your work will meet the task requirements! 👍
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| VALUES (1, 'AwersomeProduct', 2, 'Warehouse-1', 'City-1, Street-1',1); | ||
| INSERT INTO ProductInventory (ID,ProductName,WarehouseAmount,WarehouseName,WarehouseAddress,CountryID) | ||
| VALUES (2, 'AwersomeProduct', 5, 'Warehouse-2', 'City-2, Street-2',2); | ||
| DROP DATABASE IF EXISTS ShopDB; |
There was a problem hiding this comment.
Critical issue: The DROP DATABASE IF EXISTS ShopDB; statement here will remove the database and all its contents, making all previous table and data creation above this line redundant. If the task requires both the unnormalized and normalized schemas, do not drop the database here. If only the normalized schema is needed, remove the initial part of the script.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job! 🎉 Your updated task.sql fully meets all the requirements: the schema is correctly normalized to 3NF, all test data is present and adapted, and the script structure is clean and correct. There are no issues remaining—keep up the excellent work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.