-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Solve #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
krzyb5081
wants to merge
6
commits into
mate-academy:master
Choose a base branch
from
krzyb5081:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Solve #2855
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,71 @@ | ||
| from __future__ import annotations | ||
|
|
||
|
|
||
| class Distance: | ||
| # Write your code here | ||
| pass | ||
| def __init__(self, km: int | float) -> None: | ||
| self.km = km | ||
|
|
||
| def __str__(self) -> str: | ||
| return f"Distance: {self.km} kilometers." | ||
|
|
||
| def __repr__(self) -> str: | ||
| return f"Distance(km={self.km})" | ||
|
|
||
| def __add__(self, other: Distance | int | float) -> Distance: | ||
| if isinstance(other, Distance): | ||
| return Distance(self.km + other.km) | ||
| if isinstance(other, int | float): | ||
| return Distance(self.km + other) | ||
| raise TypeError | ||
|
|
||
| def __iadd__(self, other: Distance | int | float) -> Distance: | ||
| if isinstance(other, Distance): | ||
| self.km += other.km | ||
| if isinstance(other, int | float): | ||
| self.km += other | ||
| return self | ||
|
|
||
| def __mul__(self, other: int | float) -> Distance: | ||
| if isinstance(other, int | float): | ||
| return Distance(self.km * other) | ||
| raise TypeError | ||
|
|
||
| def __truediv__(self, other: int | float) -> Distance: | ||
| if isinstance(other, int | float): | ||
| return Distance(round(self.km / other, 2)) | ||
| raise TypeError | ||
|
|
||
| def __lt__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km < other.km | ||
| if isinstance(other, int | float): | ||
| return self.km < other | ||
| return NotImplemented | ||
|
|
||
| def __le__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km <= other.km | ||
| if isinstance(other, int | float): | ||
| return self.km <= other | ||
| return NotImplemented | ||
|
|
||
| def __gt__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km > other.km | ||
| if isinstance(other, int | float): | ||
| return self.km > other | ||
| return NotImplemented | ||
|
|
||
| def __ge__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km >= other.km | ||
| if isinstance(other, int | float): | ||
| return self.km >= other | ||
| return NotImplemented | ||
|
|
||
| def __eq__(self, other: Distance | int | float) -> bool: | ||
| if isinstance(other, Distance): | ||
| return self.km == other.km | ||
| if isinstance(other, int | float): | ||
| return self.km == other | ||
| return NotImplemented | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method still uses an
elifand a trailingraise TypeErrorafter theif, which goes against checklist item "Avoid unnecessaryelsestatements" and the previous guidance to remove trailing branches returning/raising afterif/elif. You can structure it asif isinstance(other, Distance): ...; if isinstance(other, (int, float)): ...; raise TypeErrorwithoutelif.