Skip to content

Solution#2847

Open
Davy-Pereira wants to merge 4 commits into
mate-academy:masterfrom
Davy-Pereira:master
Open

Solution#2847
Davy-Pereira wants to merge 4 commits into
mate-academy:masterfrom
Davy-Pereira:master

Conversation

@Davy-Pereira

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because several core behaviors of the Distance class still do not match the task requirements and will cause tests to fail. The string methods __str__ and __repr__ do not produce the exact required formats, which is critical for the specified output checks. Arithmetic methods have blocking issues: __add__, __iadd__, and __mul__ use incorrect type annotations, include str as a supported type, and in some cases return str instead of Distance or self, and __mul__ currently divides rather than multiplies. A required feature, __truediv__, is missing entirely, but the task specifies that distance1 / 7 must work and return a new Distance with km rounded to two decimals, so this must be implemented with other: int | float only [CHECKLIST ITEM #3]. The comparison methods (__lt__, __gt__, __le__, __ge__, __eq__) have incorrect type hints (including str) and buggy isinstance(int, float) checks that never inspect other, so comparisons with numbers will not behave as required; these need to be corrected to use Distance | int | float and isinstance(other, (int, float)). Please also remove unnecessary else/elif branches that follow a return (to align with [CHECKLIST ITEM #1]) and fix all return type annotations so arithmetic methods return Distance and comparison methods return bool [CHECKLIST ITEM #2]. Once you address these functional and type-related issues, the implementation will be much closer to the expected behavior; the whitespace/linting problems are minor and can be cleaned up after the core fixes are in place.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py Outdated
Comment thread app/main.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants