Add brute solution with multiprocessing#917
Conversation
danyatatarchuk
commented
Jul 8, 2026
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am approving your solution because it correctly brute-forces the full 8-digit numeric space (0–99,999,999), uses SHA-256 with UTF-8 encoding via sha256_hash_str, and prints each discovered password and its corresponding hash, which satisfies the core functional requirements. Your multiprocessing approach using cpu_count() and chunked ranges is a solid optimization that aligns well with the performance expectations and does not introduce any obvious correctness issues. While the code does not explicitly assert that exactly 10 passwords were found, it does exhaustively search the required space and will find all matches that exist in the provided hash set, so this is not a blocking issue for task completion.
For a future improvement (non-blocking), consider adding a final check like len(found_passwords) == len(PASSWORDS_TO_BRUTE_FORCE) and printing a warning if the counts don’t match, which would make it easier to confirm you’ve recovered all expected passwords [CHECKLIST ITEM #3, #4]. You could also sort the results before printing to make manual verification simpler. Remember to attach the required console-output screenshot(s) to your PR, since that part is handled outside the code. Overall, you’ve met the key requirements and shown good use of multiprocessing; well done.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨