Skip to content

first commit#4186

Open
tkrylataja wants to merge 2 commits into
mate-academy:masterfrom
tkrylataja:develop
Open

first commit#4186
tkrylataja wants to merge 2 commits into
mate-academy:masterfrom
tkrylataja:develop

Conversation

@tkrylataja

Copy link
Copy Markdown
  • DEMO LINK

  • Keyframes implemented using from/to + transform with rotate property

  • Stopwatch is centered and has the correct arrows size

  • All Typical Mistakes from the BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because one critical requirement from the task description is not yet met, and it affects the tested functionality. The stopwatch works visually and functionally, but the stopwatch--speed-up modifier is not applied to the HTML element, so the required “speed-up” test mode never becomes active.

Critical issue to fix (blocker):

  1. In src/index.html, your root stopwatch element is currently something like:
    <div class="stopwatch">
    The task explicitly requires: “Add the modifier to the stopwatch for tests. Mentors will remove it via Dev Tools and check if Basic functionality works as expected.” To satisfy this, you need to change it to:
    <div class="stopwatch stopwatch--speed-up">
    This ensures the speed-up mode (10s for seconds, 600s for minutes) is active by default for tests, as specified.

All other core requirements (sizes, colors, animations, durations, and BEM modifier styling) appear correctly implemented. Once you add the stopwatch--speed-up class to the main stopwatch element, your solution will align with the task description and should be ready for approval. You’re very close—this is just a small but important functional detail to correct.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/index.html Outdated
</head>
<body>
<h1>Stop watch</h1>
<div class="stopwatch">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the requirement: Add the modifier to the stopwatch for tests. Mentors will remove it via Dev Tools and check if Basic functionality works as expected. You’ve defined the stopwatch--speed-up modifier in SCSS, but it’s not applied here. Consider changing this to class="stopwatch stopwatch--speed-up" so the speed-up mode is active by default for tests.

Comment thread src/styles/index.scss
transform: translateX(-50%) rotate(0deg);
}
to {
transform: translateX(-50%) rotate(360deg);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main stopwatch element is missing the stopwatch--speed-up BEM modifier class. The description requires: "Add the modifier to the stopwatch for tests. Mentors will remove it via Dev Tools and check if Basic functionality works as expected." Consider changing this to class="stopwatch stopwatch--speed-up" so the speed-up mode is active for tests.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it now fully meets the functional and visual requirements of the stopwatch task. The root element correctly uses both stopwatch and stopwatch--speed-up, ensuring the accelerated mode for tests works as intended. The stopwatch is centered with flexbox, sized to 80vmin x 80vmin, and styled with the required dotted circular border and correctly colored minute, second, and center elements. Both hands start from the top, use only CSS animations, and follow the specified timing: 60s linear for seconds, 3600s with steps(60) for minutes, and 10s/600s overrides in speed-up mode. BEM naming is consistent and avoids the typical mistakes mentioned in the theory, satisfying [CHECKLIST ITEM #3]. Nicely done bringing everything in line with the checklist and requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants