Skip to content

add solution#4163

Open
lubovmrk wants to merge 1 commit into
mate-academy:masterfrom
lubovmrk:develop
Open

add solution#4163
lubovmrk wants to merge 1 commit into
mate-academy:masterfrom
lubovmrk:develop

Conversation

@lubovmrk

Copy link
Copy Markdown
  • DEMO LINK

  • Keyframes implemented using from/to + transform with rotate property

  • Stopwatch is centered and has the correct arrows size

  • All Typical Mistakes from the BEM lesson theory are checked.

  • Code follows all the [Code Style Rules ❗️]

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved because it fully meets the functional and visual requirements of the task and satisfies all checklist items. The stopwatch is correctly centered, sized to 80vmin with a 1vmin dotted circular border, and includes the properly styled center circle, minute hand, and second hand, all starting from the top and animating infinitely with the correct durations and timing functions. Both hands use only CSS animations with a shared @keyframes using from/to and transform: rotate(...), and the minutes hand correctly uses steps(60) to complete a full circle in 60 minutes. The stopwatch--speed-up modifier correctly speeds up the seconds hand to 10 seconds per rotation and the minutes hand to 10 minutes per rotation without breaking other behavior, and the HTML applies this modifier as required for testing.

One minor, non-blocking improvement: in src/styles/index.scss you could nest the modifier inside the .stopwatch block, for example:

.stopwatch {
  // base styles

  &--speed-up {
    // modifier styles
  }
}

This keeps the BEM block and its modifier visually grouped in SCSS and aligns with common BEM nesting practices, but your current approach still compiles to valid CSS and does not violate the task requirements. Nicely done on implementing all the timing details and BEM naming correctly.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/styles/index.scss
}
}

.stopwatch--speed-up .stopwatch__minutes {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving this modifier’s styles inside the .stopwatch block and using BEM nesting (e.g., .stopwatch { &--speed-up { ... } }) to align with BEM best practices mentioned in checklist item #3 about typical mistakes.

Comment thread src/styles/index.scss
animation-duration: 600s;
}

.stopwatch--speed-up .stopwatch__seconds {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for minutes: this modifier block should ideally be nested within .stopwatch using &--speed-up to keep modifier styles coupled to the block, as per BEM guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants