Skip to content

Implement stars block#6903

Open
VadymMararenko wants to merge 1 commit into
mate-academy:masterfrom
VadymMararenko:homework-stars
Open

Implement stars block#6903
VadymMararenko wants to merge 1 commit into
mate-academy:masterfrom
VadymMararenko:homework-stars

Conversation

@VadymMararenko

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly meets all core functional requirements for the Stars Block. All six stars blocks with modifiers (stars--0 through stars--5), the flexbox layout, background-image implementation, and CSS :nth-child(-n + N) selectors for active stars are working as expected. The BEM naming convention is properly applied throughout. Regarding the checklist item #2 about separating each BEM block into its own file: while splitting CSS into a dedicated stars.css file would follow BEM best practices for larger projects, this is an organizational preference rather than a functional blocker. Your code is functionally complete and correct as submitted. One minor optimization you may consider: you have a redundant margin-right declaration on .stars__star (line 13) that's also repeated via the :not(:last-child) selector (lines 18-19). The :not rule is unnecessary since all stars already have the margin and the last child's margin doesn't affect the layout in this flex context. However, this is purely optional and doesn't affect functionality.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/style.css
@@ -1 +1,28 @@
/* add styles here */
html,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #2 violation: 'Each BEM block has its own separate file'. While all CSS is in one style.css file, BEM methodology typically requires each block to have its own CSS file. Consider splitting into separate files like stars.css and using multiple <link> tags or @import in HTML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants