create layout stars#6894
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because there are still checklist violations that are considered core requirements for this task. First, the rule “Each BEM block has its own separate file” [CHECKLIST ITEM #2] is not followed: all stars styles currently live in src/style.css instead of a dedicated file (e.g. src/blocks/stars/stars.css or similar), so you should move all .stars and .stars__star rules there and keep style.css only for global/base styles if needed. Second, the requirement to “Use semantic tags where possible” is not fully met: the top-level wrapper for the rating group in src/index.html is a generic <div> (around lines where all the .stars blocks live); replace that wrapper with a more semantic element such as <main> or <section> that better reflects the page structure.
Functionally your solution is very solid: the six stars blocks, modifiers stars--0 through stars--5, background-image usage, and flex layout all look correct and clean. Once you split the BEM block styles into their own file and adjust the top-level wrapper to a semantic tag, your solution will fully align with the task requirements. You're close—fixing these structural points will bring it over the finish line.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
|
|
There was a problem hiding this comment.
This violates checklist item #2: "Each BEM block has its own separate file". All styles for the stars block are currently placed in style.css; you need to move the stars-related rules into a dedicated CSS file for this BEM block and keep the separation consistent.
| margin: 0; | ||
| } | ||
|
|
||
| .stars { |
There was a problem hiding this comment.
This violates checklist item "Each BEM block has its own separate file" – all styles, including the stars block, are collected in style.css instead of being split into separate files per BEM block.
| margin-right: 4px; | ||
| } |
There was a problem hiding this comment.
According to checklist item "Use semantic tags where possible", consider replacing a generic top-level <div> wrapper for the rating group with a more semantic container element (e.g. main or section) to better reflect the page structure.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
3 participants
Checklist
❗️ Replace
<your_account>with your Github username and copy the links toPull Requestdescription:❗️ Copy this
Checklistto thePull Requestdescription after links, and put- [x]before each point after you checked it.Typical MistakesfromBEMlesson theory are checked.