Skip to content

add solution#6887

Open
MarcelloTar wants to merge 2 commits into
mate-academy:masterfrom
MarcelloTar:develop
Open

add solution#6887
MarcelloTar wants to merge 2 commits into
mate-academy:masterfrom
MarcelloTar:develop

Conversation

@MarcelloTar

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there are still a couple of checklist-level requirements not met, which are considered critical for this task. First, [CHECKLIST ITEM #2] says that each BEM block must have its own separate file, but all stars block styles (for .stars, .stars__star, and modifiers) are currently in src/style.css instead of a dedicated file such as src/stars.css; you should move all stars-related rules there and link that file from index.html. Second, the description states “Don’t add vertical margins between blocks,” but the six stars blocks are rendered as block-level divs one under another, which creates vertical stacking and spacing by default; you can fix this by wrapping them in a parent container and arranging them according to the Figma layout (typically horizontally) so there is no vertical block-to-block margin. Also, make sure any layout or visual styling is applied via classes rather than directly on the body element, keeping body limited to global reset rules. Functionally, your implementation of the stars, modifiers, and pseudo-selectors is solid and meets the core behavior requirements, so once you address the file separation and layout issues, your solution should be fully compliant. Keep going—you’re very close; these changes are mainly about matching the structural and layout rules of the task more precisely.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/style.css Outdated
margin: 0;
}

.stars {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Each BEM block has its own separate file. All styles for the stars block (including elements and modifiers) are currently placed in this common style.css file instead of a separate block-specific file.

Comment thread src/style.css Outdated
height: 16px;
background-repeat: no-repeat;
background-position: center;
margin-right: 4px;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the task description: Don't add vertical margins between blocks. Using multiple block-level div elements one after another without a container or alternative layout causes them to stack vertically, effectively introducing vertical spacing between stars blocks. Consider wrapping them in a container and arranging them according to the Figma design to avoid vertical margins between blocks.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution because it now meets all of the core task requirements and passes the critical checklist items. You have exactly six stars blocks with five stars__star elements each, and the modifiers stars--0 through stars--5 correctly control how many yellow stars are shown using container modifiers plus :nth-child() selectors, without extra classes on the stars themselves. The stars are implemented with background-image instead of <img> or <svg>, and the .stars block uses display: flex without gap, with spacing handled via margins as required. Global layout is handled via the .pages class rather than styling body directly, and each BEM block (page, stars) has its own CSS file imported from style.css, aligning with the project’s BEM and file-structure rules. Overall, your implementation is clean, respects the constraints, and functionally behaves as specified, so it is accepted as a correct solution.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants