Skip to content

finished task, but unfinished tests#6877

Open
nikiccey wants to merge 1 commit into
mate-academy:masterfrom
nikiccey:develop
Open

finished task, but unfinished tests#6877
nikiccey wants to merge 1 commit into
mate-academy:masterfrom
nikiccey:develop

Conversation

@nikiccey

@nikiccey nikiccey commented Jul 4, 2026

Copy link
Copy Markdown

https://nikiccey.github.io/layout_stars/
https://nikiccey.github.io/layout_stars/report/html_report/

  • [x ] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • [x ] All Typical Mistakes from BEM lesson theory are checked.
  • [ x] Code follows all the Code Style Rules ❗️

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am requesting changes because there are still critical checklist and requirements violations in your CSS setup. First, in src/style.css you use the universal selector * { margin: 0; box-sizing: border-box; }, which breaks the explicit rule “Don’t use * selector in CSS” and the requirement to reset browser default margins via html/body only; switch this to html, body { margin: 0; } and move box-sizing to an allowed pattern (e.g., via a root class) if needed. Second, all styles are in a single style.css file, while the task requires that each BEM block have its own separate stylesheet [CHECKLIST ITEM #2]; you should extract the stars block styles into a dedicated file like stars.css and include it from your HTML. These issues are considered blockers because they contradict explicit task and checklist rules, even though your functional behavior for the stars (correct modifiers, flex layout, and active star count) is otherwise solid. As you revise, also ensure you add a font-family with a generic fallback (e.g., font-family: "YourFont", sans-serif;) to comply with the code style rules, and remove any remaining disallowed selectors. Once these structural and style-rule fixes are in place, your solution should be ready to pass, since the core functionality is already well implemented.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/style.css
Comment on lines +2 to +5
* {
margin: 0;
box-sizing: border-box;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist rule: "Don't use * selector in CSS"; also the requirement is to reset browser default margin, which should be done without the universal selector (e.g. via html/body).

Comment thread src/style.css
Comment on lines +7 to +30
.stars__star {
background-image: url(../src/images/star.svg);
background-repeat: no-repeat;
width: 16px;
height: 16px;
margin-right: 4px;
}

.stars__star:last-child {
margin: 0;
}

.stars {
display: flex;
margin: 0;
}

.stars--1 .stars__star:nth-child(1),
.stars--2 .stars__star:nth-child(-n + 2),
.stars--3 .stars__star:nth-child(-n + 3),
.stars--4 .stars__star:nth-child(-n + 4),
.stars--5 .stars__star:nth-child(-n + 5) {
background-image: url(../src/images/star-active.svg);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item "Each BEM block has its own separate file" because all BEM styles for the stars block are kept in a single general stylesheet instead of a dedicated block file.

@etojeDenys etojeDenys left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants