finished task, but unfinished tests#6877
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because there are still critical checklist and requirements violations in your CSS setup. First, in src/style.css you use the universal selector * { margin: 0; box-sizing: border-box; }, which breaks the explicit rule “Don’t use * selector in CSS” and the requirement to reset browser default margins via html/body only; switch this to html, body { margin: 0; } and move box-sizing to an allowed pattern (e.g., via a root class) if needed. Second, all styles are in a single style.css file, while the task requires that each BEM block have its own separate stylesheet [CHECKLIST ITEM #2]; you should extract the stars block styles into a dedicated file like stars.css and include it from your HTML. These issues are considered blockers because they contradict explicit task and checklist rules, even though your functional behavior for the stars (correct modifiers, flex layout, and active star count) is otherwise solid. As you revise, also ensure you add a font-family with a generic fallback (e.g., font-family: "YourFont", sans-serif;) to comply with the code style rules, and remove any remaining disallowed selectors. Once these structural and style-rule fixes are in place, your solution should be ready to pass, since the core functionality is already well implemented.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| * { | ||
| margin: 0; | ||
| box-sizing: border-box; | ||
| } |
There was a problem hiding this comment.
This violates checklist rule: "Don't use * selector in CSS"; also the requirement is to reset browser default margin, which should be done without the universal selector (e.g. via html/body).
| .stars__star { | ||
| background-image: url(../src/images/star.svg); | ||
| background-repeat: no-repeat; | ||
| width: 16px; | ||
| height: 16px; | ||
| margin-right: 4px; | ||
| } | ||
|
|
||
| .stars__star:last-child { | ||
| margin: 0; | ||
| } | ||
|
|
||
| .stars { | ||
| display: flex; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .stars--1 .stars__star:nth-child(1), | ||
| .stars--2 .stars__star:nth-child(-n + 2), | ||
| .stars--3 .stars__star:nth-child(-n + 3), | ||
| .stars--4 .stars__star:nth-child(-n + 4), | ||
| .stars--5 .stars__star:nth-child(-n + 5) { | ||
| background-image: url(../src/images/star-active.svg); | ||
| } |
There was a problem hiding this comment.
This violates checklist item "Each BEM block has its own separate file" because all BEM styles for the stars block are kept in a single general stylesheet instead of a dedicated block file.
https://nikiccey.github.io/layout_stars/
https://nikiccey.github.io/layout_stars/report/html_report/
Typical MistakesfromBEMlesson theory are checked.