add task solution#6870
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because one explicit checklist requirement is not met: each BEM block must have its own separate CSS file, and currently the stars block styles are all inside src/style.css. This is a structural requirement, not just a style preference, so it counts as a critical blocker for this task. To fix this, move the .stars and .stars__star rules (and any related modifiers like .stars--0 … .stars--5) from src/style.css into a dedicated block file, for example src/stars.css. Then, update index.html to include that new stylesheet according to your project’s conventions (either via a <link> tag in the <head> or via a main CSS file that imports stars.css). Aside from this file-structure issue, your implementation of the block count, modifiers, flex layout, and background-image usage looks solid and matches the functional requirements well. Once you correct the CSS file separation, your solution should fully comply with the task and checklist. Keep going—you’re very close; this is mainly about aligning with the required BEM project structure.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved because it correctly implements all core functional and structural requirements for the stars rating block. The HTML has 6 .stars blocks, each with 5 .stars__star elements and the proper stars--0 through stars--5 modifiers, and the CSS uses background-image, flex layout, and nth-child selectors without extra classes to control active stars, all in line with the task and checklist. There are no issues that break functionality or violate the main mandatory constraints, and the separate stars.css file imported from style.css matches the BEM and file-structure requirements.
One non-blocking improvement is semantic HTML usage: right now the rating content is inside a single div under <body>, and wrapping the group of stars in a semantic container like <main> or <section> would better satisfy the “Use semantic tags where possible” guideline [CHECKLIST ITEM]. This is a good enhancement to keep in mind for future tasks, but it doesn’t prevent this solution from meeting the current task’s goals. Overall, you handled the modifiers, layout, and CSS separation well—nice work on aligning your implementation with the required rating behavior and styling constraints.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| @@ -13,6 +13,47 @@ | |||
| /> | |||
| </head> | |||
| <body> | |||
There was a problem hiding this comment.
This violates checklist item: "Use semantic tags where possible". Right now all rating content is inside plain div elements; consider wrapping the stars blocks in a semantic container like main or section to better describe the page content.
2 participants
DEMO LINK
TEST REPORT LINK
Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
Each BEM block has its own separate file
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️