Skip to content

Develop#2749

Open
MarekBiela wants to merge 5 commits into
mate-academy:masterfrom
MarekBiela:develop
Open

Develop#2749
MarekBiela wants to merge 5 commits into
mate-academy:masterfrom
MarekBiela:develop

Conversation

@MarekBiela

@MarekBiela MarekBiela commented Jun 25, 2026

Copy link
Copy Markdown

Index without navigation
DEMO LINK

@natalia-klonowska natalia-klonowska left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start :) remember about CHECKLIST

  • there're several BEM naming issues in your project. I've marked one example of each type of mistake but please fix all similar cases

  • consider adding max-width so that on screens wider than 1260px only side margins continue to grow because right now some sections become too stretched (e.g in Contact Us section the two content columns are pushed to opposite sides of the screen leaving large empty space between them

  • adjust image positioning so that it is cropped correctly

Image
  • change cursor to pointer for all buttons and links (make sure all addresses are clickable links)
Image Image

Comment thread index.html
<main class="main">
<section class="hours">
<div class="hours--left">
<div class="main__font main__font--highlight main__font--highlight-small">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typical BEM Mistakes: Using an Element Inside Another Block

Comment thread index.html
Museum hours
</h2>
</div>
<div class="hours--right">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typical BEM Mistakes: Using a Modifier Without the Belonging Class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants