add task solution#2747
Open
jkumorek01 wants to merge 6 commits into
Open
Conversation
natalia-klonowska
suggested changes
May 5, 2026
natalia-klonowska
left a comment
There was a problem hiding this comment.
- imgs should maintain proper proportions so that they don’t look cropped or zoomed in
- icons shouldn't change position on hover
- Add a favicon
- Change text color on hover for phone, email and address
- When you click on phone icon or phone number in contacts section, make sure that there is no 404 error, make it a real link to start a call on device
- When clicking on any location / address - prevent errors and make it to open location in Google Maps
- Pictures in Gallery should increase on hover
- Placeholders in the forms suggest what to enter; apply validation of the form fields (required, email / tel etc.), then it is clear in what format to enter the data
- Form shouldn't be submitted if some of the fields are not filled
- Page shouldn't be reloaded on form submit
- disable page scrolling under the menu
danon321
suggested changes
May 12, 2026
danon321
left a comment
There was a problem hiding this comment.
Desktop
Tutaj na figmie jak zobaczysz wszystkie elementy maja te sama szerokosc. Mozesz stworzyc specjalna klase pod to container ktora bedzie zamykała twoj kontent w pudełku z odpowiednią
U ciebie kazdy z tych elementow zyje własnym zyciem:
(na tym screenie na maksa oddaliłem ekran ale i tak elementy powinny trzymac sie dobrze)
danon321
suggested changes
May 13, 2026
danon321
left a comment
There was a problem hiding this comment.
Nic sie nie zmieniło w linku do DEMO
https://jkumorek01.github.io/layout_miami/
Author
|
I have updated the demo link |
natalia-klonowska
suggested changes
May 15, 2026
natalia-klonowska
left a comment
There was a problem hiding this comment.
Mobile
- pojawia ci się scroll poziomy. tytuł i ikony są zbyt duże oraz cała nawigacja jest zbyt przesunięta w dół
- wszystkie tytuły są zbyt duże
- niektóre zdjęcia są błędnie przybliżone. w drugim wierszu brakuje jednego zdjęcia. opisy pod zdjęciami powinny mieć większe odstępy miedzy wierszami. button powinien rozciągać się aż do miejsca gdzie kończą się pozostałe elementy sekcji
- paddingi sekcji są zbyt duże
danon321
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first task solution + demo link: https://jkumorek01.github.io/layout_miami/