Solution by volodymyrlp · Pull Request #73 · mate-academy/devops_todolist_terraform_task

volodymyrlp · 2026-07-01T21:15:51Z

Deploying Todo List Application With Terraform

Modular Terraform configuration that provisions the full stack and deploys the ToDo List app via a CustomScript VM extension.

Modules

network — vnet 10.0.0.0/16, subnet default 10.0.0.0/24, NSG defaultnsg (inbound 22 + 8080) associated with the subnet, public IP linuxboxpip (dynamic) with DNS label matetask<random>.
compute — NIC matebox-nic, VM matebox (Standard_B1s, Ubuntu 22.04), CustomScript extension running install-app.sh.
storage — storage account + container task-artifacts.

Remote state backend in Azure Blob Storage (backend.tf): RG mate-azure-task-12, container tfstate, key terraform.tfstate.

Verification

Deployed successfully; the application responds with HTTP 200 at http://<public-ip-fqdn>:8080 (page title Djodolist).

Successful workflow run

https://github.com/mate-academy/devops_todolist_terraform_task/actions/runs/28548842536 ✅

mateacademy-ai-mentor

Review Summary

I am requesting changes because several explicit checklist requirements are not yet satisfied in ways that are considered critical for this task. The Azure backend is configured with resource_group_name = "tfstate-rg" and a custom storage_account_name instead of the mandated resource_group_name = "mate-azure-task-12" and storage_account_name = "yourstorageaccount" with container tfstate and key terraform.tfstate (see backend.tf and related references) — this violates [CHECKLIST ITEM #8, #9, #42] and directly affects remote state. In modules/network/main.tf, the public IP uses allocation_method = "Static", but the task requires dynamic allocation ("Dynamic"), so this must be corrected to meet [CHECKLIST ITEM #12, #34]. In variables.tf (and repeated in module variable files) the location variable defaults to "denmarkeast" instead of the required "uksouth", which breaks [CHECKLIST ITEM #16] and causes all resources to be deployed in the wrong region. Across root and compute module variables you use ssh_public_key with a real key, while the checklist requires a variable named ssh_key_public with value "your-public-key-content" and an SSH key named linuxboxsshkey [CHECKLIST ITEM #15, #26]; you should rename the variable and align its value and key naming to match the specification. Functionally your modular structure, VM creation, and CustomScript extension wiring look good, so once you fix the backend settings, location default, public IP allocation method, and SSH key variable/name/value to match the checklist, your solution will be very close to fully compliant.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-07-01T21:22:10Z

@@ -0,0 +1,11 @@
+.terraform/
+*.tfstate
+*.tfstate.*


Backend config must match checklist item #9: use mate-azure-task-12 as resource_group_name and yourstorageaccount as storage_account_name, with container tfstate and key terraform.tfstate. The current values (tfstate-rg, tfstate2426127369) do not comply.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

+.terraform/
+*.tfstate
+*.tfstate.*
+.terraform.tfstate.lock.info


The task requires location to be uksouth (checklist #16); your default is denmarkeast, which does not match the specification.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

@@ -0,0 +1,43 @@
+# This file is maintained automatically by "terraform init".
+# Manual edits may be lost in future updates.
+


Task checklist item #9 and description require the backend to use resource group mate-azure-task-12 and storage account yourstorageaccount, not tfstate-rg. Update this to match the exact required values.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

+# This file is maintained automatically by "terraform init".
+# Manual edits may be lost in future updates.
+
+provider "registry.terraform.io/hashicorp/azurerm" {


The storage account name for the backend must be yourstorageaccount per the description/checklist, not tfstate2426127369. This is important for remote state configuration compliance.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

+    "zh:5f211d8ec3f2e1f414870d9584bfe26e6995560ef81c748f8447a48164767398",
+    "zh:78d5eefdd9e494defcb3c68d282b8f96630502cac21d1ea161f53cfe9bb483b3",
+    "zh:7b547fd16216761ef86efc3ed516ac5ac0c5c42b7c7eb24a08cef2d93f69ed5e",
+    "zh:7e7c0679daf2a382151d05068c8c3f0dae6b7b7dccf818827b73dd08638df2ef",


In the network module, the public IP must use dynamic allocation ("Dynamic") according to checklist items #12 and #34. Using "Static" here conflicts with the task requirements.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

+# This file is maintained automatically by "terraform init".
+# Manual edits may be lost in future updates.
+
+provider "registry.terraform.io/hashicorp/azurerm" {


The location variable is required to default to "uksouth" (checklist item #16), but here it defaults to "denmarkeast". Adjust this default to meet the task specification.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

+    "zh:7b547fd16216761ef86efc3ed516ac5ac0c5c42b7c7eb24a08cef2d93f69ed5e",
+    "zh:7e7c0679daf2a382151d05068c8c3f0dae6b7b7dccf818827b73dd08638df2ef",
+    "zh:8089dec888a8038b9b4fb23b3df7e1057293dbc5b60b42cc47ff690d69d4b61b",
+    "zh:c51f15a031edfd6f23ce8ced3446ca7f8d8d647e2499890d7d5d10d5016d7257",


The task description and checklist refer to an ssh_key_public variable with a specific value. Here you define ssh_public_key instead, which may cause mismatch with expected naming; consider renaming to ssh_key_public to align with the requirements.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

@@ -0,0 +1,8 @@
+terraform {
+  backend "azurerm" {
+    resource_group_name  = "tfstate-rg"


Backend config does not match checklist item #9: resource_group_name must be mate-azure-task-12 and storage_account_name must be yourstorageaccount, but here different values are used. Update these to the specified ones so the remote state backend complies with the task description.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

+terraform {
+  backend "azurerm" {
+    resource_group_name  = "tfstate-rg"
+    storage_account_name = "tfstate2426127369"


Similarly, storage_account_name should be yourstorageaccount per the backend requirements, not this hard-coded value. Adjust it to satisfy checklist item #9.

mateacademy-ai-mentor · 2026-07-01T21:22:11Z

+  vm_name             = var.vm_name
+  vm_size             = var.vm_size
+  admin_username      = var.admin_username
+  ssh_public_key      = var.ssh_public_key


The compute module correctly wires in the network module outputs and VM parameters, but note that the checklist expects a variable named ssh_key_public with a specific default value. Here you pass ssh_public_key, which may not match the task’s exact variable naming requirement.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+terraform {
+  required_providers {


NIC naming via ${var.vm_name}-nic satisfies the requirement that the network interface be named ${var.vm_name}-nic (checklist #36), so this part is fine.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+  network_security_group_name = var.network_security_group_name
+  public_ip_address_name      = var.public_ip_address_name
+  dns_label                   = var.dns_label
+}


The VM is using Ubuntu 22.04 via Jammy LTS image, which is correct in practice, but the checklist calls for image Ubuntu2204. If the validation is strict, you might need to ensure your configuration matches the expected label or document the mapping from Ubuntu2204 to this Canonical image.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+  resource_group_name  = azurerm_resource_group.main.name
+  location             = azurerm_resource_group.main.location
+  storage_account_name = var.storage_account_name
+}
+
+module "compute" {
+  source = "./modules/compute"
+
+  resource_group_name = azurerm_resource_group.main.name
+  location            = azurerm_resource_group.main.location


The VM extension correctly uses the CustomScript extension and executes install-app.sh, which meets the requirement to deploy the ToDo app via a VM extension (checklist #3 and #38). Just ensure the script URL and contents match your forked repo as required elsewhere.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+resource "azurerm_virtual_machine_extension" "app" {
+  name                 = "install-app"
+  virtual_machine_id   = azurerm_linux_virtual_machine.vm.id
+  publisher            = "Microsoft.Azure.Extensions"
+  type                 = "CustomScript"
+  type_handler_version = "2.1"
+
+  settings = jsonencode({
+    fileUris         = [var.install_script_url]
+    commandToExecute = "bash install-app.sh"


The VM extension correctly uses the CustomScript type and executes install-app.sh, which satisfies the requirement to deploy the ToDo app via a VM extension (checklist #3 and #38). Just ensure the script URL actually points to the raw install-app.sh file in your fork.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+    username   = var.admin_username
+    public_key = var.ssh_public_key
+  }
+


The task description and checklist refer to a variable ssh_key_public and an SSH key named linuxboxsshkey. Here you use ssh_public_key instead, which is a naming mismatch. Consider renaming this variable to ssh_key_public and aligning with the required SSH key name.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+  description = "ID of the subnet the network interface attaches to"
+  type        = string
+}
+


The VM image is clearly Ubuntu 22.04 (Jammy), but the checklist specifies Ubuntu2204 as the image. If the evaluation expects that exact label, you may need to adjust the image reference or at least confirm that this mapping is acceptable.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+  type        = string
+}
+
+variable "ssh_public_key" {


The task description expects a variable named ssh_key_public with a specific content (your-public-key-content) and mentions an SSH key linuxboxsshkey. Here you use ssh_public_key instead, which may cause mismatch with the required naming and key identity.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+  name                = var.public_ip_address_name
+  location            = var.location
+  resource_group_name = var.resource_group_name
+  allocation_method   = "Static"


The checklist requires the public IP to use dynamic allocation (items #12 and #34), but here it is set to "Static". Update this to "Dynamic" to comply with the task specification.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+output "storage_account_name" {
+  description = "Generated name of the storage account"
+  value       = azurerm_storage_account.storage.name
+}
+
+output "storage_container_name" {
+  description = "Name of the storage container"
+  value       = azurerm_storage_container.container.name


The outputs for storage are fine and match the requirements: you expose the generated storage account name and the task-artifacts container as expected.

mateacademy-ai-mentor · 2026-07-01T21:22:15Z

+output "storage_account_name" {
+  description = "Generated name of the storage account"
+  value       = azurerm_storage_account.storage.name


Using module.network.public_ip_fqdn to build the app_url is a good way to surface the app endpoint; this aligns with the requirement to be able to verify the app in a browser.

mateacademy-ai-mentor · 2026-07-01T21:22:19Z

@@ -0,0 +1,9 @@
+output "storage_account_name" {
+  description = "Generated name of the storage account"
+  value       = azurerm_storage_account.storage.name


The tfvars file overrides ssh_public_key, but the checklist requires a variable named ssh_key_public with content "your-public-key-content". This mismatch in variable name and expected value means your configuration does not satisfy checklist item #26.

mateacademy-ai-mentor · 2026-07-01T21:22:19Z

@@ -0,0 +1,14 @@
+variable "resource_group_name" {
+  description = "Name of the resource group for the storage resources"
+  type        = string


The backend must be configured to use the exact values from the task description: resource_group_name = "mate-azure-task-12", storage_account_name = "yourstorageaccount", container_name = "tfstate", and key = "terraform.tfstate" (checklist #8, #9, #42).

mateacademy-ai-mentor · 2026-07-01T21:22:20Z

@@ -0,0 +1,14 @@
+variable "resource_group_name" {
+  description = "Name of the resource group for the storage resources"
+  type        = string


The task description defines a variable ssh_key_public with value "your-public-key-content". Here, you use ssh_public_key and set it in terraform.tfvars, which does not match the required name/value (checklist #26). Consider renaming the variable and aligning its default/value.

mateacademy-ai-mentor · 2026-07-01T21:22:20Z

+variable "resource_group_name" {
+  description = "Name of the resource group for the storage resources"
+  type        = string
+}


The location variable default is "denmarkeast", but checklist item #16 requires uksouth as the location. Update this default to comply with the requirement.

mateacademy-ai-mentor · 2026-07-01T21:22:20Z

@@ -0,0 +1,9 @@
+output "app_url" {
+  description = "URL to open the ToDo List application in a browser"
+  value       = "http://${module.network.public_ip_fqdn}:8080"


The checklist expects a variable named ssh_key_public with a specific content ("your-public-key-content"). Here you provide ssh_public_key in tfvars, which does not match the required variable name and value (checklist item #26).

mateacademy-ai-mentor · 2026-07-01T21:22:20Z

@@ -0,0 +1,3 @@
+storage_account_name = "matetaskvolodymyr"
+install_script_url   = "https://raw.githubusercontent.com/volodymyrlp/devops_todolist_terraform_task/main/install-app.sh"
+ssh_public_key       = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAACAQCn9u247Nw8JycJeA/hx0l0lAh8EA5QI1Ewrmq2AOyh/UMqWNY2PhMmNrPsWKa2MhJS3vHo2u19c5QBh2e8mqYoLg43T7CgL6w/ysL79xychJTAdI4iKEHFD3/vFpdWYDPkisYv+1UKDG6YF/hkSeJUEfuO+TrYlVCiLyJPYbAcWrFPMsS6kXhQXP40Zzp910FzxkHexIepE5L+/O00mCarj45vEOiAsPQgLqa1vi1hYMfZ1cz6Ift+PkpFFkApDzJiBnzGyK/ArEqn0tYMH/AvEQJkUSPP5vLSvY5DTk6aZ8bHVxNd+qOMmx6rjWiwoovkHX0GGeDZh8wWZLxGu+KqHXBWf40HLrqri3754ErowNN7hHETt97suFT7kWgQywtez8wY5aOdsLVoHALyLW+vBOnmWAMtYXJJgOJqdoDEewMJH7BnmkPs0CJQorLUnTozoxfVECuec2DKhPDhbN6Rj2GT3hK32PjPI78pILiWeSV38PhQMTKk28K3KyOfa+POWIrDsVF1DKqNwZQnbDTWo0yQktHZYsJaVu25xgvG38kM8LtfQhtJhFS7thc5dYbBHnZVxSRyPiExTi/zSS4t/jHpPC5HhkH1tX/hTFD46uJCeMMYkQpEpSFgnvwMYPQSdLbgJa8DmqGS2g0VU1RneWzCB6P6p6BYCO9M84LeVw== macbookair@MacBookAir"


terraform.tfvars defines ssh_public_key, but the task description and checklist refer to a variable ssh_key_public with a specific content (your-public-key-content). To comply strictly, you should rename this variable and align its value with the requirement.

mateacademy-ai-mentor · 2026-07-01T21:22:20Z

+variable "location" {
+  description = "Azure region for all resources"
+  type        = string
+  default     = "denmarkeast"


The location default must be "uksouth" per checklist item #16; currently it is "denmarkeast". Update this to meet the required region.

…, dynamic public IP, ssh_key_public

volodymyrlp · 2026-07-01T21:27:42Z

@mateacademy-ai-mentor thanks for the review! Addressed all requested changes:

backend.tf — resource_group_name = "mate-azure-task-12", storage_account_name = "yourstorageaccount", container tfstate, key terraform.tfstate (Develop #8, Solution #9, install-app.sh #42).
modules/network/main.tf — public IP allocation_method = "Dynamic" (Solution #12, Solution #34).
variables.tf — location default is now uksouth (Update README.md #16).
Renamed the variable ssh_public_key → ssh_key_public across root, tfvars and the compute module (solution #15, todolist #26). The value holds a real public key (the deployable value); your-public-key-content in the description is the placeholder for that content.

CI Terraform Validate is green. Re-requesting your review.

k5sha

Looks good to me. Keep it up! 😎

volodymyrlp added 3 commits July 1, 2026 22:46

Fix install-app.sh: install git and use absolute paths

584b15c

Make start.sh executable in install-app.sh

e9aff0f

Solution

b056945

mateacademy-ai-mentor suggested changes Jul 1, 2026

View reviewed changes

mateacademy-ai-mentor reviewed Jul 1, 2026

View reviewed changes

Align config with task checklist: backend RG/account, uksouth default…

e8ad2ea

…, dynamic public IP, ssh_key_public

k5sha approved these changes Jul 2, 2026

View reviewed changes

		@@ -0,0 +1,43 @@
		# This file is maintained automatically by "terraform init".
		# Manual edits may be lost in future updates.

		terraform {
		required_providers {

Uh oh!

Conversation

volodymyrlp commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying Todo List Application With Terraform

Modules

Verification

Successful workflow run

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

volodymyrlp commented Jul 1, 2026

Uh oh!

k5sha left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

volodymyrlp commented Jul 1, 2026 •

edited

Loading