feat: solution for task by spridoloba · Pull Request #61 · mate-academy/devops_todolist_terraform_task

spridoloba · 2026-04-10T15:57:26Z

https://github.com/mate-academy/devops_todolist_terraform_task/actions/runs/24251815367

mateacademy-ai-mentor

Review Summary

Changes are needed before this can be considered complete because several configuration and scripting problems will either break the deployment or violate explicit task requirements.

In backend.tf, the storage_account_name is set to "prydolobba" instead of the required "yourstorageaccount", and you must ensure the tfstate container exists there so terraform init can use the remote backend as specified.
The VM size is wrong in multiple places: variables.tf (default), terraform.tfvars, and outputs.tf all use Standard_B2ts_v2 instead of the required Standard_B1s, so you need to align all of these to Standard_B1s to match the task.
In the network module (modules/network/main.tf), the public IP resource currently has allocation_method = "Static" but the requirement is Dynamic, so update that attribute accordingly.
The install-app.sh logic (both in the root script and the version embedded in the CustomScript command) is currently unreliable: apt-get update -yq uses invalid flags, git is not installed before git clone, the clone points to a different repo and no explicit target directory, and the cp source path to the app (devops_todolist_terraform_task/app/*) does not match where the extension actually clones (/devops_todolist_terraform_task)—please fix this by (1) either removing the clone from the script and relying on the extension’s clone, or installing git and using the same repo URL/target, and (2) copying from a consistent, absolute path (e.g. /devops_todolist_terraform_task/app/*) with mkdir -p /app and checks that todoapp.service exists before moving it.
In variables.tf, the ssh_key_public variable is declared but missing the required default of "your-public-key-content", so add that placeholder (keeping it sensitive = true) or clearly ensure it is always provided via terraform.tfvars in line with the task instructions.

Once you address these blockers, your module structure (network/compute/storage wiring, Ubuntu 22.04 image, DNS label logic, etc.) should be in good shape, and the deployment will be much more reliable—your current layout shows solid progress, you just need to tighten these configuration and script details to fully meet the specification.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-04-10T16:00:37Z

+override.tf
+override.tf.json
+*_override.tf
+*_override.tf.json


If you keep the git clone inside this script, you must ensure git is installed. Either remove the clone (recommended, since the extension already clones), or install git here: apt-get install git -yq before calling git clone.

mateacademy-ai-mentor · 2026-04-10T16:00:37Z

 mkdir /app 
 # make sure to uncomment the line bellow and update the link with your GitHub username
-# git clone https://github.com/<your-gh-username>/azure_task_12_deploy_app_with_vm_extention.git
+git clone https://github.com/spridoloba/azure_task_12_deploy_app_with_vm_extention.git


This git clone uses a different repository URL and has no explicit target directory. The compute module already clones the repo into /devops_todolist_terraform_task before running this script, so this line is redundant and likely incorrect — remove it or replace it with the same github_repo_url and explicit target devops_todolist_terraform_task to avoid mismatches.

mateacademy-ai-mentor · 2026-04-10T16:00:37Z

 # make sure to uncomment the line bellow and update the link with your GitHub username
-# git clone https://github.com/<your-gh-username>/azure_task_12_deploy_app_with_vm_extention.git
+git clone https://github.com/spridoloba/azure_task_12_deploy_app_with_vm_extention.git
 cp -r devops_todolist_terraform_task/app/* /app


The cp -r devops_todolist_terraform_task/app/* /app line assumes a relative path. Make it explicit and robust: either use the absolute path /devops_todolist_terraform_task/app/* (since the module clones there) or use a script-relative path like cp -r "$(dirname "$0")/app"/* /app. Also ensure the source directory exists (after fixing the clone issue).

mateacademy-ai-mentor · 2026-04-10T16:00:37Z

@@ -13,7 +13,7 @@ apt-get install python3-pip -yq
 # Create a directory for the app and download the files. 
 mkdir /app 


Use mkdir -p /app so the command is idempotent and won't fail if the directory already exists.

mateacademy-ai-mentor · 2026-04-10T16:00:37Z

+terraform {
+  backend "azurerm" {
+    resource_group_name  = "mate-azure-task-12"
+    storage_account_name = "prydolobba"


The backend configuration uses storage_account_name = "prydolobba" but the task requires the backend to use storage account name yourstorageaccount. Update this to match the task or document why a different account is used and ensure the specified container tfstate exists in that account.

mateacademy-ai-mentor · 2026-04-10T16:00:37Z

+    "zh:d340db7973109761cfc27d52aa02560363337c908b2c99b3628adc5a70a99d5b",
+    "zh:d5a577226ebc8c65e8f19384878a86acc4b51ede4b4a82d37c3b331b0efcd4a7",
+    "zh:e2962b147f9e71732df8dbc74940c10d20906f3c003cbfaa1eb9fabbf601a9f0",
+    "zh:f569b65999264a9416862bca5cd2a6177d94ccb0424f3a4ef424428912b9cb3c",


Moving /app/todoapp.service will fail if the service file wasn't copied. Add a check that the file exists (e.g., if [ -f /app/todoapp.service ]; then mv ...; else echo "service file missing"; fi) or ensure the earlier copy succeeded before moving.

mateacademy-ai-mentor · 2026-04-10T16:00:38Z

+network_security_group_name = "defaultnsg"
+public_ip_address_name      = "linuxboxpip"
+vm_name                     = "matebox"
+vm_size                     = "Standard_B2ts_v2"


The task requires the virtual machine size to be Standard_B1s, but here vm_size is set to Standard_B2ts_v2. Change this to Standard_B1s to meet the requirement.

mateacademy-ai-mentor · 2026-04-10T16:00:38Z

+}
+
+output "storage_account_name" {
+  value = module.storage.storage_account_name


The task specification requires the VM size to be Standard_B1s, but here vm_size is set to Standard_B2ts_v2. Change this value to Standard_B1s so the deployment meets the requirement.

mateacademy-ai-mentor · 2026-04-10T16:00:38Z

+variable "vm_size" {
+  type    = string
+  default = "Standard_B2ts_v2"


The task requires the VM size default to be Standard_B1s, but this variable's default is Standard_B2ts_v2. Change the default to Standard_B1s so the deployment matches the specification (checklist/requirements).

mateacademy-ai-mentor · 2026-04-10T16:00:38Z

+variable "ssh_key_public" {
+  type      = string
+  sensitive = true


The ssh_key_public variable is declared but has no default. The task's variable list requires ssh_key_public default to be your-public-key-content. Add default = "your-public-key-content" (and keep sensitive = true) or ensure this value is provided via terraform.tfvars, per the requirements.

Losiev

Well done!

feat: solution for task

4f15068

mateacademy-ai-mentor suggested changes Apr 10, 2026

View reviewed changes

Losiev approved these changes Apr 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: solution for task#61

feat: solution for task#61
spridoloba wants to merge 1 commit into
mate-academy:mainfrom
spridoloba:develop

spridoloba commented Apr 10, 2026 •

edited

Loading

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

mateacademy-ai-mentor Apr 10, 2026

Uh oh!

Losiev left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -13,7 +13,7 @@ apt-get install python3-pip -yq
		# Create a directory for the app and download the files.
		mkdir /app

Uh oh!

Conversation

spridoloba commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Losiev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spridoloba commented Apr 10, 2026 •

edited

Loading