Implement modules, remote state backend and VM extension deployment#51
Implement modules, remote state backend and VM extension deployment#51KyryloKilin wants to merge 3 commits into
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your project has a solid modular structure, which is great to see. However, I'm requesting a few changes as some key configurations don't match the task requirements and will cause deployment failures.
Here are the main points to address:
- Backend State: In
backend.tf, theresource_group_nameandstorage_account_nameneed to be updated to match the values specified in the task. - Deployment Script: The
install-app.shscript will fail because it's missing commands to installgitand the Python dependencies fromrequirements.txt. - Public IP: The public IP in
modules/network/main.tfis configured asStaticwith aStandardSKU. The requirement is forDynamicallocation, which requires aBasicSKU. - Naming and Location: Please update the default values in
variables.tfforlocation(touksouth) andvm_name(tomatebox). The network interface name should also be constructed dynamically inmain.tfas${var.vm_name}-nicrather than using a separate variable.
Once these items are corrected, your solution should work as expected. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great progress on your Terraform configuration! The modular structure is excellent, and you've addressed almost all the previous feedback. However, a small but critical issue in install-app.sh requires a change. The apt-get install command is incomplete because it's missing the package name (git) and the -yq flags for non-interactive installation. This error will cause the VM extension to fail, preventing the application from being deployed. Please correct the line to apt-get install -yq git to fix the deployment.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this project! I am approving your solution. Your Terraform configuration is perfectly structured, with clean and effective modules for networking, compute, and storage. You've also successfully addressed the feedback from the previous review by correcting the install-app.sh script. The entire project adheres to best practices and fully meets all requirements. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.