Skip to content

Implement modules, remote state backend and VM extension deployment#51

Open
KyryloKilin wants to merge 3 commits into
mate-academy:mainfrom
KyryloKilin:develop
Open

Implement modules, remote state backend and VM extension deployment#51
KyryloKilin wants to merge 3 commits into
mate-academy:mainfrom
KyryloKilin:develop

Conversation

@KyryloKilin

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your project has a solid modular structure, which is great to see. However, I'm requesting a few changes as some key configurations don't match the task requirements and will cause deployment failures.

Here are the main points to address:

  • Backend State: In backend.tf, the resource_group_name and storage_account_name need to be updated to match the values specified in the task.
  • Deployment Script: The install-app.sh script will fail because it's missing commands to install git and the Python dependencies from requirements.txt.
  • Public IP: The public IP in modules/network/main.tf is configured as Static with a Standard SKU. The requirement is for Dynamic allocation, which requires a Basic SKU.
  • Naming and Location: Please update the default values in variables.tf for location (to uksouth) and vm_name (to matebox). The network interface name should also be constructed dynamically in main.tf as ${var.vm_name}-nic rather than using a separate variable.

Once these items are corrected, your solution should work as expected. Keep up the good work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread main.tf Outdated
Comment thread backend.tf Outdated
Comment thread backend.tf Outdated
Comment thread install-app.sh
Comment thread install-app.sh
Comment thread modules/network/main.tf Outdated
Comment thread modules/network/main.tf Outdated
Comment thread variables.tf Outdated
Comment thread variables.tf Outdated
Comment thread variables.tf Outdated

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great progress on your Terraform configuration! The modular structure is excellent, and you've addressed almost all the previous feedback. However, a small but critical issue in install-app.sh requires a change. The apt-get install command is incomplete because it's missing the package name (git) and the -yq flags for non-interactive installation. This error will cause the VM extension to fail, preventing the application from being deployed. Please correct the line to apt-get install -yq git to fix the deployment.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread install-app.sh Outdated

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this project! I am approving your solution. Your Terraform configuration is perfectly structured, with clean and effective modules for networking, compute, and storage. You've also successfully addressed the feedback from the previous review by correcting the install-app.sh script. The entire project adheres to best practices and fully meets all requirements. Great job!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants