Terraform: deploy ToDo app with network, compute and storage modules#50
Terraform: deploy ToDo app with network, compute and storage modules#50maximprysyazhnikov wants to merge 2 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is a great effort, and the overall structure of your Terraform project is well-organized. However, I'm requesting a few changes as some key resource parameters don't align with the task requirements. Once these are addressed, it should be good to go.
Here are the required changes:
- VM Size & Location: In
terraform.tfvars, please update thevm_sizetoStandard_B1sand thelocationtouksouth. - Public IP Allocation: In
modules/network/main.tf, the public IP address must use aDynamicallocation method. Remember to also set itsskutoBasicto support dynamic allocation. - Backend Storage Account: In
backend.tf, thestorage_account_nameneeds to be set to the required placeholder value,yourstorageaccount.
Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| provider "azurerm" { | ||
| features {} | ||
| subscription_id = "2beb95a1-e310-40c7-926c-e1fc7424d0e4" |
There was a problem hiding this comment.
Hardcoding the subscription_id here can make your configuration less portable and is generally not recommended. It's better practice to let Terraform authenticate using the Azure CLI context or service principal environment variables, which will automatically select the correct subscription.
| terraform { | ||
| backend "azurerm" { | ||
| resource_group_name = "mate-azure-task-12" | ||
| storage_account_name = "tfstatemaks01" |
There was a problem hiding this comment.
The task description requires the storage account name for the backend to be yourstorageaccount. Please update this value to match the requirement.
| location = var.location | ||
| resource_group_name = var.resource_group_name | ||
|
|
||
| allocation_method = "Static" |
There was a problem hiding this comment.
The task requirements specify that the public IP address should use a Dynamic allocation method. This is currently set to Static. Note that to use dynamic allocation, the sku for the public IP must be set to Basic, not Standard.
| @@ -0,0 +1,18 @@ | |||
| location = "northeurope" | |||
There was a problem hiding this comment.
The task requirements specify the location should be uksouth. Please update this value.
| public_ip_address_name = "linuxboxpip" | ||
|
|
||
| vm_name = "matebox" | ||
| vm_size = "Standard_DS1_v2" |
There was a problem hiding this comment.
The required virtual machine size is Standard_B1s, but Standard_DS1_v2 is used here. Please update the vm_size to match the task requirements.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! You've successfully implemented all the required Azure resources and structured the Terraform modules perfectly, meeting all functional requirements.
The automated check failed due to a minor formatting issue in terraform.tfvars. This is a common style issue that can be easily fixed for future commits by running terraform fmt -recursive in your project directory.
Since this doesn't affect the functionality of your code, I am happy to approve your solution. Great job addressing all the previous feedback!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.