terraform vm#48
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on structuring your Terraform project with modules! The core logic is solid. However, I'm requesting a few changes to align the configuration with the specific requirements of the task.
First, in backend.tf, please update the resource_group_name to mate-azure-task-12 and the storage_account_name to yourstorageaccount. Next, in modules/network/main.tf, the public IP's allocation_method should be changed from Static to Dynamic. Finally, please update the location in your terraform.tfvars file to uksouth.
After you make these adjustments, your infrastructure will match all the requirements. You're very close!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| terraform { | ||
| backend "azurerm" { | ||
| resource_group_name = "tfstate-backend-rg" |
There was a problem hiding this comment.
The resource_group_name does not match the required value. According to the task description, it should be mate-azure-task-12.
| terraform { | ||
| backend "azurerm" { | ||
| resource_group_name = "tfstate-backend-rg" | ||
| storage_account_name = "yaroslavastorageaccount" |
There was a problem hiding this comment.
The storage_account_name does not match the value specified in the task description. It should be yourstorageaccount.
| name = var.public_ip_address_name | ||
| location = var.location | ||
| resource_group_name = var.resource_group_name | ||
| allocation_method = "Static" |
There was a problem hiding this comment.
The task requirements specify that the public IP address should use a 'dynamic' allocation method. This is currently set to 'Static'.
| @@ -0,0 +1,18 @@ | |||
| location = "westeurope" | |||
There was a problem hiding this comment.
The task requirements specify the location should be uksouth. Please update this value to match the requirement.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
This is excellent progress, and your Terraform configuration is now correctly implemented according to all requirements. However, there is one small but critical issue that is causing the automated checks to fail, so I have to request a change.
The file modules/compute/ main.tf has a leading space in its name. Please rename it to modules/compute/main.tf to resolve the issue.
This is the only thing blocking your submission. Once that file is renamed, the checks should pass. Great job addressing all the previous feedback!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! I am happy to approve your submission. You've successfully addressed the file naming issue from the previous review, and the entire Terraform configuration is now perfect. The project is well-structured, all modules are implemented correctly, and it meets every requirement of the task. This is a high-quality solution. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.