solution

[Chornoknysh]

No description provided.

[mateacademy-ai-mentor]

Review Summary

Your project has a great modular structure, but several critical issues are preventing it from meeting the core requirements. Changes are needed before this can be approved.

Here are the blockers that must be addressed:

1. Resource Group Creation: The root main.tf must define and create the Azure Resource Group using an azurerm_resource_group resource. Currently, it relies on a pre-existing one.
2. Deployment Script URL: The azurerm_virtual_machine_extension in modules/compute/main.tf uses a placeholder URL. You need to replace <твій-юзернейм> and <repo> with your actual GitHub username and repository name so the application can be deployed.
3. Missing Variable Defaults: The task requires all variables in the root variables.tf to have specified default values. These are currently missing.
4. Incorrect Backend Name: In backend.tf, the storage_account_name needs to be updated to yourstorageaccount to match the task instructions.

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

1. Rate AI review example ↩

2. Re-request AI review example ↩

3. Add AI review comments example ↩

[mateacademy-ai-mentor]

According to the task description, the Terraform configuration should create the Azure Resource Group. This resource definition is missing from the root module. You should add an azurerm_resource_group resource here and use its name when calling the modules below.

[mateacademy-ai-mentor]

According to the task requirements, the storage_account_name for the remote backend configuration should be yourstorageaccount. Please update this value to match the instructions.

[mateacademy-ai-mentor]

The URL for the install-app.sh script is a placeholder. You need to replace <твій-юзернейм> and <repo> with your actual GitHub username and repository name so that the script can be downloaded and executed on the virtual machine.

[mateacademy-ai-mentor]

The task requirements state that all variables in the root variables.tf should be defined with default values. Currently, all variables are declared without defaults. Please add the default values as specified in the task description (e.g., default = "uksouth" for the location variable).

[mateacademy-ai-mentor]

Review Summary

Excellent work on this submission! You've successfully addressed all the critical feedback from the previous review, and your Terraform configuration now meets all the core requirements of the task. I am happy to approve your solution.

For future reference, there is a minor improvement you could make regarding the duplicated random_integer resource. It's currently defined in both the root main.tf and the network module. A common best practice is to define such resources only once (in the root module) and pass the value to any modules that need it. This follows the "Don't Repeat Yourself" (DRY) principle and improves maintainability.

This is just a suggestion for improvement and doesn't block the approval. Great job getting this project to a fully functional state!

---

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Footnotes

1. Rate AI review example ↩

[mateacademy-ai-mentor]

This random_integer resource is a good way to ensure unique names. However, the network module also defines its own identical random_integer resource.

To avoid duplication and improve consistency, it's better to define this resource only once here in the root main.tf. You can then pass the result (random_integer.rand.result) as a variable to the network module, just as you've done for the storage module.

[mateacademy-ai-mentor]

This resource correctly generates a random number for the DNS label. However, there's a similar random_integer resource defined in the root main.tf.

To avoid duplication and centralize the random number generation, it's a best practice to remove this resource from the module. You can add a new variable to modules/network/variables.tf to accept the random number and pass it in from the root main.tf.

[mateacademy-ai-mentor]

To follow the best practice of defining a resource only once, consider adding a new variable here to receive the random number generated in the root main.tf. For example:

variable "random_suffix" {
  type = number
}

You could then pass random_integer.rand.result from the root module to this new variable and remove the duplicate random_integer resource from this module's main.tf.