Skip to content

<building and running the container> #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Margarita926 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

<building and running the container> #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e55705
<building and running the container>
Jun 26, 2026
b954c99
<add a second FROM for the runtime>
Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
ARG PYTHON_VERSION=3.8
FROM python:${PYTHON_VERSION} AS builder
WORKDIR /app
COPY requirements.txt .
RUN pip install --no-cache-dir -r requirements.txt
COPY . .
RUN python manage.py migrate

FROM python:3.8-slim
ENV PYTHONUNBUFFERED=1
WORKDIR /app
COPY --from=builder /app .
EXPOSE 8080
CMD ["python", "manage.py", "runserver", "0.0.0.0:8080"]

12 changes: 12 additions & 0 deletions INSTRUCTION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@


@mateacademy-ai-mentor mateacademy-ai-mentor Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task explicitly requires the Dockerfile to have both a build stage and a run stage (multi-stage build), but this file only defines a single stage; consider adding a separate FROM for a final runtime stage and using this one as the builder (checklist item #2).

# ToDo App Docker Image
## Docker Hub
https://hub.docker.com/repository/docker/margarita8454/todoapp/general
## Запуск
Comment on lines +3 to +6

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions mention that INSTRUCTION.md should include build and run steps and describe how to access the app in a browser; this section only covers pull/run commands and omits build steps and a note like open http://localhost:8080 (checklist items #13 and #14).


docker pull margarita8454/todoapp:1.0.0
docker run -d -p 8080:8080 margarita8454/todoapp:1.0.0
docker build -t todoapp:1.0.0 .
Comment on lines +8 to +10

@mateacademy-ai-mentor mateacademy-ai-mentor Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions list the correct docker pull, docker run, and docker build commands, but they are not wrapped in a Markdown code block. The previous review requested properly closed ``` sections; consider enclosing these commands between opening and closing triple backticks to improve readability and avoid rendering issues.


## How to access the app in the browser => http://localhost:8080/
Loading