-
Notifications
You must be signed in to change notification settings - Fork 331
- #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
- #320
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| ARG PYTHON_VERSION=3.10-slim | ||
|
|
||
| FROM python:${PYTHON_VERSION} AS builder | ||
| WORKDIR /app | ||
| COPY requirements.txt . | ||
|
|
||
| RUN pip install --user --no-cache-dir -r requirements.txt | ||
|
|
||
| FROM python:${PYTHON_VERSION} AS runner | ||
| WORKDIR /app | ||
|
|
||
| ENV PYTHONUNBUFFERED=1 | ||
|
|
||
| COPY --from=builder /root/.local /root/.local | ||
| ENV PATH=/root/.local/bin:$PATH | ||
| COPY . . | ||
|
|
||
| RUN python manage.py migrate | ||
|
|
||
| CMD ["python", "manage.py", "runserver", "0.0.0.0:8080"] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Інструкція з запуску програми ToDo App | ||
|
|
||
| ## Посилання на Docker Hub | ||
| Офіційний образ проекту знаходиться за посиланням: | ||
| [Docker Hub Repository](https://hub.docker.com/r/1berkut1/todoapp) | ||
| http://localhost:8080/ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This standalone URL line does not clearly state that the user should open it in a browser after running the container. The checklist and previous review require a sentence such as: "Open |
||
|
|
||
| ## Як зібрати образ локально | ||
| ```bash | ||
| docker build -t 1berkut1/todoapp:1.0.0 . | ||
|
Comment on lines
+8
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The instructions currently only show how to build the image. The task and previous review require a complete |
||
| ``` | ||
Uh oh!
There was an error while loading. Please reload this page.