Skip to content
Open

- #320

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
ARG PYTHON_VERSION=3.10-slim

FROM python:${PYTHON_VERSION} AS builder
WORKDIR /app
COPY requirements.txt .

RUN pip install --user --no-cache-dir -r requirements.txt

Comment thread
1berkut1 marked this conversation as resolved.
FROM python:${PYTHON_VERSION} AS runner
WORKDIR /app

ENV PYTHONUNBUFFERED=1

COPY --from=builder /root/.local /root/.local
ENV PATH=/root/.local/bin:$PATH
COPY . .

RUN python manage.py migrate

CMD ["python", "manage.py", "runserver", "0.0.0.0:8080"]
11 changes: 11 additions & 0 deletions todolist/INSTRUCTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Інструкція з запуску програми ToDo App

## Посилання на Docker Hub
Офіційний образ проекту знаходиться за посиланням:
[Docker Hub Repository](https://hub.docker.com/r/1berkut1/todoapp)
http://localhost:8080/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This standalone URL line does not clearly state that the user should open it in a browser after running the container. The checklist and previous review require a sentence such as: "Open http://localhost:8080/ in your browser to use the ToDo app."


## Як зібрати образ локально
```bash
docker build -t 1berkut1/todoapp:1.0.0 .
Comment on lines +8 to +10

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions currently only show how to build the image. The task and previous review require a complete docker run example with port mapping and the 1.0.0 tag (e.g. docker run -p 8080:8080 1berkut1/todoapp:1.0.0) so users know exactly how to start the container.

```
Loading