Skip to content

add task solution#728

Open
Natalia-Onufrienko wants to merge 21 commits into
mate-academy:masterfrom
Natalia-Onufrienko:develop
Open

add task solution#728
Natalia-Onufrienko wants to merge 21 commits into
mate-academy:masterfrom
Natalia-Onufrienko:develop

Conversation

@Natalia-Onufrienko

Copy link
Copy Markdown

@brespect brespect left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, check next:

  1. There should be no extra right margin:
Image
  1. These buttons do nothing on Mobile view:
Image
  1. Form should reset after submit:
Image

@brespect brespect left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comment still not fixed

@brespect brespect left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, but

  1. For now the problem repeats for top section:
Image
  1. Also, check the Figma Mockup Images positioning, for now the Girl has no head in your implementation:
Image Image

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants