SOF-7915: export physical constants via python interface#46
Open
pranabdas wants to merge 21 commits into
Open
Conversation
pranabdas
commented
Jun 3, 2026
| return re.sub(r"[!#].*$", "", text, flags=re.MULTILINE) | ||
|
|
||
| # Default (shell): Removes lines starting with # (except shebang) | ||
| return re.sub(r"^(\s+)?#(?!!).*$", "", text, flags=re.MULTILINE) |
Member
Author
There was a problem hiding this comment.
Should we remove inline comments as well?
Member
There was a problem hiding this comment.
Isn't # not a comment mark in Fortran?
Googling gives: # shows up in Fortran files mainly from the C preprocessor (#include, #ifdef, etc.) -- probably should not be deleted
Member
Author
There was a problem hiding this comment.
You are right. Thank you, Seth.
| return re.sub(r"#.*$", "", text, flags=re.MULTILINE) | ||
| return re.sub(r"#(?!!).*$", "", text, flags=re.MULTILINE) | ||
| patterns = { | ||
| "espresso": r"[!#].*$", # ! or # comments |
Member
There was a problem hiding this comment.
utils should not know about espresso
remove espresso comments by chaining fortran and python comments
| ) -> Any: | ||
| """ | ||
| Executes a regex search using a configuration schema block. | ||
| The schema is based on the regex repo: |
Member
There was a problem hiding this comment.
Should be defined inside the regex repo then
| return python_flags | ||
|
|
||
|
|
||
| def regex_search(content: str, pattern: Union[str, re.Pattern], flags: int = 0, find_all: bool = False) -> Any: |
Member
There was a problem hiding this comment.
Should have a test for it
timurbazhirov
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.